Repository navigation
refactor(tools)!: delete hub-calling tool packages; Myra ships stock tools-mail and tools-posix (CL-8471) - #892
Merged
Conversation
…tools-mail and tools-posix (CL-8471)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Myra's live run failed at step start: her tool factories demanded env keys the
stock sidecar never supplies (
hubCapabilitiesUrl,sidecarToken,tenantId,principalId,definitionId, ...). The root cause is not wiring — Interchangehas no concept of an agent calling the hub API. A tool gets the env
createSidecarStepBuildEnvbuilds (sources, storage, workdir, toolCwd,transport, address, capabilities, deps, directors), and upstream's own tool
packages are
tools-mail,tools-posixandtools-lsp: none of them reachesthe hub. So the hub-calling tool packages were a Workbench invention with no
platform behind them.
What changed
Deleted, whole:
tools/access,tools/agent-directory,tools/capability,tools/catalog,tools/interaction,tools/skills,tools/workflow-authoring— thetools/workspace root goes with them(workspaces, lint/fmt globs, typecheck and run-all globs,
tsconfig.build.jsonreferences, README layout row).
Also deleted:
packages/inference-catalog—tools/catalogwas its only consumer(
apps/hubdeclared the dependency but imported nothing from it), plus thethree docs that documented it and the doc for the capability route deleted
with
packages/agent-directory.apps/web/src/tools/registry-publish.tsandtarball.ts(and their tests):they existed to pack and publish
tools/*into the tenant'scorbits-toolsregistry, and there is nothing left to publish. The onboarding and
workbench-create flows no longer call the publish step. The Tools page and
registry-read.tsstay — they list whatever a tenant has published.agents/myra/src/tool-packages.ts(pins for the deleted packages; the sourcelineage resolves no pins anyway).
Myra's factories are now upstream's, from their published sidecar bundles:
mailfrom@intx/tools-mail/sidecar-bundleandposixfrom@intx/tools-posix/sidecar-bundle(both0.3.0from npm).@corbits/memorytools are dropped for now — that library still requires memory env keys and is
cut over separately.
Her system prompt says, thinly, what is true now: she has mail and a working
tree; to stand up an agent or workflow she writes the package and asks the
person to deploy it from Workbench; capabilities, connections and access are
approvals the person makes in the UI.
Verification
bun run typecheck,bun run lint,bun run fmt/fmt:check,bun run test(all workspaces) — clean.cd agents/myra && bun run build— bundle builds with no unresolved bareimports.
export default buildMyraWorkflow({...})):stepOrder: ["assistant"],toolPackagePins: [], factories@intx/tools-mail/sidecar-bundle(requires: ["capabilities","address"], mail_send/reply/search/read/wait) and@intx/tools-posix/sidecar-bundle(requires: [], read_file/write_file/run_shell/edit_file/search_files/grep).
Not verified: nothing was exercised against a live hub — the dev stack was not
started or restarted. The live check after merge is a run whose turn calls a
mail or posix tool instead of failing env validation.