Repository navigation
feat(web): Workflows lists only workflows; Agents is a roster with a Chat action (CL-8455) - #890
Merged
Merged
Conversation
…Chat action (CL-8455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/workflows) no longer lists Myra's own deploy source or any hand-authored agent —routines-api.tsnow filters deployments whose backingworkflow-kind asset name isMYRA_SOURCE_CONFIG.assetNameor matchesagent-<slug>-source(the exact namingagent-deploy.tsalready owns, exported asisAgentDeploySourceAssetName). Both markers are asset-naming, not runtime state, so the list stays accurate without a live-run lookup./agents) is now a plain roster: display name, Live/Starting status, and a "Chat" action that opens/chats/<assetId>via the existing chat path helpers. It reads throughlistChatAgents(chat/threads-api.ts) — the same source the chat picker already uses — instead of the old workflow-definitions/instances model.chatKeys.agentsquery key, invalidated byuseDeployAgentMutation.Deleted
apps/web/src/pages/agent-detail-page.tsxand its route (AGENT_DETAIL_PATH) — health/events/approvals detail view had no remaining use once the roster stopped linking to it.apps/web/src/agents-directory.ts— the workbench-host-filtering/display-name binding it provided was only consumed by the roster and detail pages just removed.agentIdFromPath(path-ids.ts) and its test — no longer referenced once the detail route is gone.agents-api.ts(useAgentDirectory,loadAgentDirectory, run health/events/approvals hooks,listAgentInstances,getAgentRun,listCatalogModels) — all were only used by the deleted pages.run-status-tone-parity.test.ts(AGENT_ROSTER_STATUS_TONE) — the roster's status vocabulary (Live/Starting, reachability) no longer overlaps withRunStatus, so the parity guard no longer applies.Test plan
bunx tsc -p apps/web --noEmitbun run fmtbun run lintcd apps/web && bun run buildbun test ./src(fromapps/web) — 584 pass