Repository navigation
fix(web): a room redeploys its released agents and names them in avatars (CL-8454) - #888
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roomnow renders anAgentRedeployerper released agent (asset present, no live run), which redeploys it through the same pathworkbench-create.tsuses:deployMyraSourcefor Myra,readAgentSource+deployAgentSourcefor anything else, then invalidates the room scope.useRefplus the mutation's ownisPending/isSuccess, oneAgentRedeployerinstance per released agent's asset id — nouseEffect.<name> is starting…" while any agent is released, matchingchat-thread-page.tsx's pattern, and the participants query polls every 3s while an agent has no live address.resolveParticipantName(participant display name, e.g. Myra → "M") instead of the raw run-address local part.RoomParticipantgained an optionalassetName, needed to redeploy/read source back for a released agent.Test plan
bunx tsc -p apps/web --noEmitbun run fmtbun run lintcd apps/web && bun run buildbun test apps/web/srcshows pre-existingdocument is not definedfailures unrelated to this change (missing DOM env in the invocation used), none in the files touched here.