Skip to content

feat(web): workflows, approvals, insights and palette read stock runs and deployments (CL-8434) - #870

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-8434-workflows-stock
Sep 18, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-8434-workflows-stock

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • routines-api.ts's listScheduledWorkflows now reads the stock GET /workflows/deployments listing joined against GET /assets?kind=workflow for a display name, instead of always returning []. Cron always reports "manual" — stock exposes no schedule-trigger projection on either read, so this is honest rather than guessed. Run-now and pause/resume stay rejected promises naming the missing stock route (deployments are list/create-only).
  • workflow-detail-page.tsx now shows a run history for the definition (GET /workflows/runs?definitionId=) with a click-to-expand event log per run (GET /workflows/runs/:runId/events).
  • mission-control-page.tsx's approve/deny actions moved off manual useState + async/await onto useMutation with onSuccess invalidation, per the TanStack Query convention.
  • command-palette-provider.tsx's two bare-scope (#, @) effect-driven fetches converted to useQuery; no useEffect-driven fetch remains in what this PR touches.
  • Verified pending-approvals.ts, insights-api.ts/insights-timeline.ts, and approval-actions.ts already read only stock /approvals and /workflows/runs — no dead route calls there to cut over.

What's left / blockers

  • grep -rnE "workflows/scheduled|chat/bench|\}/inbox|chat/workbenches" apps/web/src still matches outside apps/web/src/chat/ — but only in pre-existing test files (agent-chat-launch.test.ts, agent-dm-launch.test.ts, instant-agent-create.test.ts, myra-workbench.test.ts, command-palette-actions.test.ts) that exercise the legitimate, still-live stock chat/workbenches route, and in approval-actions.ts's cache-invalidation predicate string (not a live fetch). None of this is workflows/scheduled or chat/bench/settings dead-route debt; it predates this PR and sits outside this ticket's scope (owned by chat/, which this PR does not touch).
  • "Bench chat settings removed or moved to localStorage" (chat/api.ts's chat/bench/settings) is explicitly out of scope — that file lives under apps/web/src/chat/, which the task instructions say not to edit (owned by another ticket).
  • Deployment pause/resume/run-now have no backing stock route (/workflows/deployments is list/create only), so those controls in the Routines UI will surface an honest "no stock route yet" error rather than working — flagging for an upstream ask rather than fabricating a route.
  • bun run scripts/run-all.ts test has one pre-existing failure/error in apps/web (src/tools/registry-publish.ts's import.meta.glob in login-routing.test.tsx) unrelated to this change — present before this branch's edits.

Test plan

  • bun install
  • bunx tsc -p apps/web --noEmit — clean
  • bun run fmt
  • bun run lint — clean (pre-existing warnings in apps/sidecar untouched)
  • bun run scripts/run-all.ts test — 931 pass, 1 pre-existing unrelated failure

@linear-code

linear-code Bot commented Sep 18, 2026

Copy link
Copy Markdown

CL-8434

@TheGreatAxios
TheGreatAxios merged commit b5e5c5e into main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant