Repository navigation
feat(web): workflows, approvals, insights and palette read stock runs and deployments (CL-8434) - #870
Merged
Merged
Conversation
… and deployments (CL-8434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routines-api.ts'slistScheduledWorkflowsnow reads the stockGET /workflows/deploymentslisting joined againstGET /assets?kind=workflowfor a display name, instead of always returning[]. Cron always reports "manual" — stock exposes no schedule-trigger projection on either read, so this is honest rather than guessed. Run-now and pause/resume stay rejected promises naming the missing stock route (deployments are list/create-only).workflow-detail-page.tsxnow shows a run history for the definition (GET /workflows/runs?definitionId=) with a click-to-expand event log per run (GET /workflows/runs/:runId/events).mission-control-page.tsx's approve/deny actions moved off manualuseState+ async/await ontouseMutationwithonSuccessinvalidation, per the TanStack Query convention.command-palette-provider.tsx's two bare-scope (#,@) effect-driven fetches converted touseQuery; nouseEffect-driven fetch remains in what this PR touches.pending-approvals.ts,insights-api.ts/insights-timeline.ts, andapproval-actions.tsalready read only stock/approvalsand/workflows/runs— no dead route calls there to cut over.What's left / blockers
grep -rnE "workflows/scheduled|chat/bench|\}/inbox|chat/workbenches" apps/web/srcstill matches outsideapps/web/src/chat/— but only in pre-existing test files (agent-chat-launch.test.ts,agent-dm-launch.test.ts,instant-agent-create.test.ts,myra-workbench.test.ts,command-palette-actions.test.ts) that exercise the legitimate, still-live stockchat/workbenchesroute, and inapproval-actions.ts's cache-invalidation predicate string (not a live fetch). None of this is workflows/scheduled or chat/bench/settings dead-route debt; it predates this PR and sits outside this ticket's scope (owned by chat/, which this PR does not touch).chat/api.ts'schat/bench/settings) is explicitly out of scope — that file lives underapps/web/src/chat/, which the task instructions say not to edit (owned by another ticket)./workflows/deploymentsis list/create only), so those controls in the Routines UI will surface an honest "no stock route yet" error rather than working — flagging for an upstream ask rather than fabricating a route.bun run scripts/run-all.ts testhas one pre-existing failure/error inapps/web(src/tools/registry-publish.ts'simport.meta.globinlogin-routing.test.tsx) unrelated to this change — present before this branch's edits.Test plan
bun installbunx tsc -p apps/web --noEmit— cleanbun run fmtbun run lint— clean (pre-existing warnings inapps/sidecaruntouched)bun run scripts/run-all.ts test— 931 pass, 1 pre-existing unrelated failure