Repository navigation
fix(hub): sidecar outbound mail persists through the mailbox-wrapped persist (CL-8429) - #865
Merged
Merged
Conversation
…persist (CL-8429) The sidecar router captured the plain session lookups before the mailbox wrapper existed, so an agent's first reply threw on the missing session and never reached @corbits/mailbox. Point the shared lookups at the wrapped persist, the same one the mailbox route and cron use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidecar router captured the plain session lookups before the mailbox-wrapped persist was built, so Myra's first reply failed with "Endpoint ... has no session" and never reached
@corbits/mailbox. The shared lookups now point at the wrapped persist (session-ensure plus principal inbox delivery), the same one the mailbox route and cron paths already use.