Repository navigation
fix(web): setup gate keys on Myra's live deployment, push tokens are per-attempt (CL-8424) - #862
Merged
Merged
Conversation
…per-attempt (CL-8424) Stock mints a deployment's workflow principal only at its first run, so a principal-based check re-ran setup on every load. The gate and the converge now read the tenant's deployments list against the workflow asset instead. Git push tokens get a unique name per attempt (active names are unique per user), and the installing effect reuses its in-flight converge under StrictMode so Myra is not deployed twice. Tests that pinned the principal-based check are deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock mints a deployment's workflow principal only at its first run, so the principal-based "Myra live" check re-ran setup on every page load. The first-login gate and the converge now key on the tenant's deployments list anchored to the
myra-deploy-sourceworkflow asset.Also: git push tokens get a unique name per attempt (active token names are unique per user, so concurrent attempts 500'd), and the installing effect reuses its in-flight converge under StrictMode so Myra is not deployed twice.
Tests pinning the principal-based check are deleted rather than adapted.