Skip to content

chore(packages): comments say why, never what; long ones move to docs/ (CL-8376) - #847

Merged
TheGreatAxios merged 8 commits into
mainfrom
cl-8376-packages-comments
Sep 18, 2026
Merged

TheGreatAxios merged 8 commits into
mainfrom
cl-8376-packages-comments

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Comments-only cleanup across packages/*/src, excluding migration-runner, hub-api-client, and credential-providers (being deleted by other PRs).
  • Deleted comments that restated what the code does; shortened "why" comments to 1-3 lines; moved genuinely deep rationale into short docs/*.md files with a one-line pointer left in code.
  • No behavior, names, or types changed.

Docs added

  • docs/tool-packing.md
  • docs/inference-concepts.md
  • docs/ollama-context-defaults.md
  • docs/offering-capabilities.md
  • docs/workflow-definition-projection.md
  • docs/run-outcome-status.md
  • docs/agent-session-provisioning.md
  • docs/workflow-authoring-registry.md
  • docs/webhook-signature-security-model.md
  • docs/agent-definition-status-lifecycle.md
  • docs/workflow-capability-authorization.md

Test plan

  • bun run check (typecheck, lint, fmt, test) green

@linear-code

linear-code Bot commented Sep 18, 2026

Copy link
Copy Markdown

CL-8376

@TheGreatAxios
TheGreatAxios force-pushed the cl-8376-packages-comments branch from 5525238 to e4c487c Compare September 18, 2026 01:55
…ry-publish, agent-events, approvals, collections, cron, error-sink, code-review

Long comment blocks that only restated what the code does are removed or
shortened to a line or two of real rationale. A few genuinely deep
explanations move to new docs/ files with a one-line link left in place.
Deep implementation rationale for source-tree validation, run-outcome
status, agent-session provisioning, and the authoring registry moves to
new docs/ files with a one-line link left in place.
Covers inventory, validation, routes, capability-inventory, capability-add,
agent-definition-drafting, one-shot-prompt, asset-write, id-leak-guard,
sanitize-inventory-text, tool-package-version. The archive/restore
lifecycle invariant for agent definitions moves to
docs/agent-definition-status-lifecycle.md.
Covers visible-definitions, workflow-create-routes, workflow-capability-routes.
The self-update authorization rationale moves to
docs/workflow-capability-authorization.md.
Trim remaining comments in agent-directory, url-path, and cron to a
short why rather than a restatement of what the code does.
Follow-up trim after rebasing onto main: shorten remaining 4-6 line
module-header comments across agent-directory, inference-catalog, and
workflows to the target 1-3 line why.
@TheGreatAxios
TheGreatAxios force-pushed the cl-8376-packages-comments branch from e4c487c to 608f298 Compare September 18, 2026 01:57
@TheGreatAxios
TheGreatAxios merged commit 08ee4a0 into main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant