Repository navigation
refactor(packages)!: delete code-review; fold agent-events, artifact-ui, tool-registry-publish into their consumers (CL-8390) - #845
Merged
Conversation
…omputes kind segments from @corbits/artifacts types
…gistry publish into apps/web, tool-registry helpers into agent-directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/code-review(dead: no app/workflow/deploy path imported it; only a test-fixture string mentioned the name).packages/agent-eventsintopackages/agent-directory/src/agent-events.ts, keeping only the two readersone-shot-prompt.tsactually imports (connectorReplyContent,messageRunEnded); dropped the unused readers (inferenceDoneBlocks,toolDoneResult,messageRunBracket,messageRunStarted) and their tests.packages/artifact-ui(theArtifactSummarytype and the Files kind-nav mapping) intoapps/web/src/library/. The hub no longer depends on the package: it now buckets@corbits/artifacts' ownArtifactListRowthrough a small hub-localapps/hub/src/library-kind-segments.tskept in step by hand with the web app's copy.packages/tool-registry-publish. Its bundling-based publish loop (bun-build + tar) is gone; a newapps/web/src/tools/registry-publish.tsreusesmyra-deploy.ts's ownpackTarballto pack eachtools/*package's raw source (directories read live off the workspace viaimport.meta.glob, so a newtools/*package needs no directory-list edit) and publish it the same way Myra's own tarball is published.tarballCoversPackageand thecorbits-toolsregistry name moved into a newpackages/agent-directory/src/tool-registry.ts;tools/access's dependency on the deleted package was unused and dropped.Notes
publishToolPackageRegistryin yet (nothing did before either — the old package's publish loop had no caller in this repo), so this is a like-for-like move with no behavior change.bun run checkandapps/web'sbun run buildare green on this branch after rebasing ontoorigin/main(which independently deletedtools/{linear,github,granola,reddit,web-search,gotenberg}andcode-reviewin the interim).Test plan
bun run check(typecheck, lint, fmt:check, test) — green, 1770 tests passingapps/web:bun run build— succeeds