Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ PRINCIPAL_KEY_ENCRYPTION_KEY=111111111111111111111111111111111111111111111111111
# RERANK_MAX_DOC_CHARS=
# RERANK_TIMEOUT_MS=

# Markdown-to-PDF rendering through a Gotenberg server.
# GOTENBERG_URL=http://localhost:3000

# Sidecars run as child processes of the hub. Both optional.
# PROCESS_PROVISIONER_SIDECAR_ENTRY=
# PROCESS_PROVISIONER_RUNTIME=
Expand Down
1 change: 0 additions & 1 deletion agents/myra/test/definition.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type { StepPrimitive, WorkflowDefinition } from "@intx/workflow";
import {
ASSISTANT_STEP_ID,
ASSISTANT_SYSTEM_PROMPT,
ASSISTANT_TOOL_PACKAGE_PINS,
ASSISTANT_WORKFLOW_ID,
buildAssistantWorkflow,
serializeAssistantWorkflow,
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/chat/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@
padding: 0;
}

/* A static fact ("this agent has @corbits/github-tools") is not a button
/* A static fact ("this agent has @corbits/example-tools") is not a button
and should not wear button chrome — no border, a muted tint fill only,
never the bordered-and-transparent look `Button variant="outline"` and
`Badge tone="neutral"` share. */
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/chat/workbench-settings/agents-section.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ describe("summarizeHistoryMessage", () => {
});

test("a capability addition names what was added", () => {
expect(summarizeHistoryMessage("Add @corbits/github-tools to Myra")).toBe(
"Added tool: @corbits/github-tools",
expect(summarizeHistoryMessage("Add @corbits/example-tools to Myra")).toBe(
"Added tool: @corbits/example-tools",
);
expect(summarizeHistoryMessage("Add research skill to Myra")).toBe("Added skill: research");
expect(summarizeHistoryMessage("Set Myra's model to anthropic/claude-sonnet")).toBe(
Expand Down
27 changes: 15 additions & 12 deletions apps/web/test/chat/agents-section.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -582,13 +582,16 @@ describe("Agents section — Capabilities", () => {
test("lists current tools/skills/model and offers only what's not already attached", async () => {
const withCapabilities: AgentFixture = {
...MYRA,
toolPackagePins: [{ name: "@corbits/github-tools", version: "*" }],
toolPackagePins: [{ name: "@corbits/example-tools", version: "*" }],
skills: ["research"],
};
stubFetch({
agents: [withCapabilities],
capabilityInventory: {
toolPackages: [{ name: "@corbits/github-tools" }, { name: "@corbits/granola-tools" }],
toolPackages: [
{ name: "@corbits/example-tools" },
{ name: "@corbits/other-example-tools" },
],
skills: [{ name: "research" }, { name: "writing" }],
models: [{ canonicalName: "anthropic/claude-sonnet" }],
},
Expand All @@ -599,7 +602,7 @@ describe("Agents section — Capabilities", () => {
await settle();

const listText = el.querySelector(".chat-settings-capability-list")?.textContent;
expect(listText).toContain("@corbits/github-tools");
expect(listText).toContain("@corbits/example-tools");
expect(listText).toContain("research");

const choiceSelect = el.querySelectorAll(
Expand All @@ -608,14 +611,14 @@ describe("Agents section — Capabilities", () => {
const toolOptions = Array.from(choiceSelect?.options ?? []).map((option) => option.value);
// The already-pinned tool package is not offered again; the
// not-yet-pinned one is.
expect(toolOptions).not.toContain("@corbits/github-tools");
expect(toolOptions).toContain("@corbits/granola-tools");
expect(toolOptions).not.toContain("@corbits/example-tools");
expect(toolOptions).toContain("@corbits/other-example-tools");
});

test("a static capability chip is a plain caption tint, not button chrome", async () => {
const withCapabilities: AgentFixture = {
...MYRA,
toolPackagePins: [{ name: "@corbits/github-tools", version: "*" }],
toolPackagePins: [{ name: "@corbits/example-tools", version: "*" }],
skills: [],
};
stubFetch({ agents: [withCapabilities] });
Expand Down Expand Up @@ -673,7 +676,7 @@ describe("Agents section — Capabilities", () => {
let addedBody: unknown;
const { refreshCalls } = stubFetch({
capabilityInventory: {
toolPackages: [{ name: "@corbits/github-tools" }],
toolPackages: [{ name: "@corbits/example-tools" }],
skills: [],
models: [],
},
Expand All @@ -696,7 +699,7 @@ describe("Agents section — Capabilities", () => {
)[1] as HTMLSelectElement | null;
act(() => {
if (choiceSelect !== null) {
choiceSelect.value = "@corbits/github-tools";
choiceSelect.value = "@corbits/example-tools";
choiceSelect.dispatchEvent(new Event("change", { bubbles: true }));
}
});
Expand All @@ -711,19 +714,19 @@ describe("Agents section — Capabilities", () => {

expect(addedBody).toEqual({
kind: "toolPackage",
name: "@corbits/github-tools",
name: "@corbits/example-tools",
});
expect(refreshCalls).toEqual(["myra@acme.example"]);
const badges = Array.from(el.querySelectorAll(".chat-settings-capability-list"))[0]
?.textContent;
expect(badges).toContain("@corbits/github-tools");
expect(badges).toContain("@corbits/example-tools");
});

test("a rejected capability add shows an inline error and never claims success", async () => {
stubFetch({
addCapabilityFails: true,
capabilityInventory: {
toolPackages: [{ name: "@corbits/github-tools" }],
toolPackages: [{ name: "@corbits/example-tools" }],
skills: [],
models: [],
},
Expand All @@ -738,7 +741,7 @@ describe("Agents section — Capabilities", () => {
)[1] as HTMLSelectElement | null;
act(() => {
if (choiceSelect !== null) {
choiceSelect.value = "@corbits/github-tools";
choiceSelect.value = "@corbits/example-tools";
choiceSelect.dispatchEvent(new Event("change", { bubbles: true }));
}
});
Expand Down
Loading
Loading