Repository navigation
test!: unit tests beside their code, integration suites under e2e/ (CL-8370) - #843
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-8370-tests-colocated-or-e2e
branch
2 times, most recently
from
September 18, 2026 01:53
12b6075 to
b423453
Compare
…nder e2e/ (CL-8370)
…regression test (CL-8370)
…tion suites under e2e/ (CL-8370)
…t globs (CL-8370)
…elper paths (CL-8370)
… e2e/browser and doomed-package suites (CL-8370) Deletes 103 apps/web unit tests that only rendered a component, pinned copy/CSS/route literals, or re-tested composition/section-registry wiring; keeps 28 that cover wire parsing, grant/approval decisions, credential/secret shaping, and dedup/reconciliation logic a user would notice break. Deletes e2e/browser/walkthrough.ts (referenced a deleted connections module and a missing harness.ts) and the e2e suites for webhook-triggers/granola/linear/tool-package-version, which depend on @corbits/credential-providers and @corbits/tool-registry-publish — both being deleted. Wires e2e/ into `bun run test` via a new `test:e2e` script that runs when DATABASE_URL is set and skips (via each suite's own dbGate banner) otherwise.
TheGreatAxios
force-pushed
the
cl-8370-tests-colocated-or-e2e
branch
from
September 18, 2026 01:57
b423453 to
7ca202c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/directory (apps/web, apps/hub, agents/myra, packages/agent-directory, packages/cron, packages/webhook-triggers, packages/workflows, tools/granola, tools/linear) plus the roottest/.src/**/*.test.ts(x)beside the module they cover; DB-backed and cross-module integration suites move toe2e/<area>/, with shared helpers (db-gate,database-url,disposable-hub-data-dir) now ine2e/lib/.packages/migration-runner/test/is left in place (only its imports of the moved root helpers were repointed) since another PR deletes that package.testfrominclude;tsconfig.src.jsonfiles already excluded*.test.ts(x); publishablepackage.jsonfileslists gained!src/**/*.test.ts(x)negations;apps/web'stestscript andbunfig.tomlpreload now point atsrc.test/tsconfig.jsonfolded intoe2e/tsconfig.json;scripts/typecheck.tschecks that instead.Test plan
bun run typecheck— no new errors (three pre-existing failures inapps/hub/src/server.ts,e2e/browser/walkthrough.ts,tools/granola/src/client.ts, none touched by this PR)bun run lintbun run fmt:checkbun run test(all workspace packages green, 1717 web unit tests included)