Repository navigation
chore(env): drop the stale EMBED_API_STYLE option (CL-8361) - #841
Merged
Merged
Conversation
@corbits/embedding has no such switch; it speaks one OpenAI-shaped /v1/embeddings wire format that Ollama, TEI, vLLM, and OpenAI all serve. Removes the line and comment from .env.example and every EMBED_API_STYLE reference in scripts/setup-memory.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env.exampledocumentedEMBED_API_STYLE=ollama|openai|tei, but@corbits/embeddinghas no such switch — it speaks one OpenAI-shaped/v1/embeddingswire format that Ollama, TEI, vLLM, and OpenAI all serve..env.exampleand everyEMBED_API_STYLEreference inscripts/setup-memory.ts.Test plan
git grep EMBED_API_STYLEreturns nothingbun run typecheckclean