Repository navigation
refactor(providers)!: consume xai and codex providers from their corbitsdev repos (CL-8321) - #823
Merged
Merged
Conversation
…ort OAuth constants (CL-8321)
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/xai-providerandpackages/codex-provider; consumers now depend ongithub:corbitsdev/corbits-xai-providerandgithub:corbitsdev/corbits-codex-provider(both public,@corbits/*name unchanged, version 0.1.0).@corbits/oauth-coreand@corbits/openai-responseswere already pinned to their corbitsdev github repos; left unchanged.package.jsonworkspaces-affecting deps andtsconfig.build.jsonreferences.Known gap — external export surface is narrower than the local packages
The external
@corbits/xai-providerand@corbits/codex-providerpackages only declare a single export (".",./src/index.ts) — there is no./constantssubpath, and theirindex.tsdoes not re-export every constant the local copies exported. Missing from@corbits/codex-provider:CODEX_CLIENT_ID,CODEX_AUTHORIZE_URL,CODEX_TOKEN_URL,CODEX_SCOPES,CODEX_AUTHORIZE_EXTRA_PARAMS,CODEX_TOKEN_TIMEOUT_MS,CODEX_ORIGINATOR. Missing from@corbits/xai-provider:XAI_AUTHORIZE_URL,XAI_CLIENT_ID,XAI_SCOPES,XAI_TOKEN_URL.I updated
packages/connections/src/registry.ts,packages/connections/src/registry.test.ts, andapps/hub/src/native-connector-registry.tsto import from the package root instead of the removed/constantssubpath, but these specific names are genuinely absent from the external package, sobun run typecheckand 3 test files (registry.test.ts,connect-github-credential-link.test.ts,plugins.test.ts) still fail on missing exports. I did not add a local shim to paper over this — it needs an upstream fix tocorbits-codex-provider/corbits-xai-provider'sindex.tsto re-export the OAuth authorize/token/client-id/scopes constants.Everything else (lint, fmt, install, package deletion/rewiring) is green.
Test plan
bun installbun run lintbun run fmtbun run typecheck— fails only on the missing exports abovebun test packages/connections apps/hub— 369 pass / 3 fail (same missing-export cause) / 16 skip (DB-gated, noDATABASE_URLlocally)