Repository navigation
chore(scripts)!: delete script tests and move e2e suites to root e2e/ (CL-8316) - #822
Merged
Merged
Conversation
Owner ruling: scripts don't need tests, and scripts/ should not carry repro/lib/git-hooks/e2e clutter. Deletes every scripts/*.test.ts (including tests of the harness, db-gate, list-suites, and db-setup), scripts/repro/, scripts/lib/ (its one file, publishable-packages.ts, was unused), scripts/git-hooks/, scripts/hooks-install.ts (and the hooks:install/prepare package.json scripts), scripts/backfill-principal-keys.ts (a one-off backfill; cutovers are breaking), scripts/generate-tsconfig-references.ts (unreferenced), and scripts/e2e/docker-sidecar-smoke.ts + list-suites.ts (unreferenced). Moves the real e2e harness and suites to a root e2e/ directory: harness.ts, db-gate.ts, database-url.ts, noop-inference-server.ts, workflow-source.ts, browser/walkthrough.ts, and the suites that still match what main actually mounts: smoke-auth, smoke-webhook, walking-skeleton, and t3-github-roundtrip.proof. Deletes smoke-chat and smoke-onboarding: smoke-chat calls chat/workbenches routes the hub no longer mounts (chat is now mail over @corbits/mailbox), and smoke-onboarding is now redundant with the tenant-creation steps already covered inside smoke-webhook/walking-skeleton. Updates every scripts/e2e import across the repo to e2e/, adds e2e to the lint/fmt/fmt:check path lists, and points `test` at `bun run scripts/run-all.ts test` (no more bun test ./scripts/*.test.ts) and `test:e2e` at `bun test e2e --max-concurrency=1`.
TheGreatAxios
force-pushed
the
scripts-cleanout
branch
from
September 17, 2026 23:37
28a81cc to
dd55a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owner ruling: we don't need to test our scripts, and scripts/ carried
repro/lib/git-hooks/e2e clutter that doesn't belong there.
scripts/*.test.*(top level andscripts/e2e/),including tests of the harness, db-gate, list-suites, and db-setup.
scripts/repro/,scripts/lib/(its only file,publishable-packages.ts, had no consumers — deleted rather thaninlined),
scripts/git-hooks/,scripts/hooks-install.ts(and thehooks:install/preparepackage.json scripts),scripts/backfill-principal-keys.ts(a one-off backfill — cutoversare breaking, no backfills),
scripts/generate-tsconfig-references.ts(unreferenced by anything, including
typecheck.ts's comments, nowupdated), and
scripts/e2e/docker-sidecar-smoke.ts+scripts/e2e/list-suites.ts(unreferenced).e2e/and moves the real harness/support files there:harness.ts,db-gate.ts,database-url.ts,noop-inference-server.ts,workflow-source.ts,browser/walkthrough.ts.scripts/db-setup.tsstays inscripts/;imports were fixed accordingly.
scripts/e2e/...import across the repo (~30 files:packages/, apps/, tools/, docs,
.gitignore,.github/workflows/ci.yml)to
e2e/....package.json:testis nowbun run scripts/run-all.ts test(no more
bun test ./scripts/*.test.ts);test:e2eisbun test e2e --max-concurrency=1;e2eadded to thelint,fmt,and
fmt:checkpath lists.Per-suite keep/delete reasoning
Checked every suite's routes/imports against what
apps/hub/src/server.tsactually mounts and what files still exist on main:
e2e/. Only touches/api/auth/*and/api/me/principals, both still mounted; importsresolve.
e2e/. UsesPOST /api/tenants, the native workflow-deploy route, and@corbits/webhook-triggers's ingress route — all still mounted.packages/tool-registry-publish,packages/hub-api-client, andagents/assistantall still exist and export what it imports.e2e/. Same route/importsurface as smoke-webhook (tenant creation, git-backed workflow asset
publish, native deploy); still current.
e2e/. Calls/api/tenants/:id/connections/github/completeand.../disconnect,which
packages/connections/src/connect-github-routes.tsstillserves.
POST /api/tenants/:id/chat/workbenchesand siblingchat/workbenches/*routes;apps/hub/src/server.tsno longer mountsany
chat/workbenchesroute — chat is now mail over@corbits/mailbox. Dead suite, not moved.POST /api/tenantsplus a benchless-signup assertion — no route orimport is stale, but it duplicates the tenant-creation hop that
smoke-webhook and walking-skeleton already cover end to end, and it
was written specifically to prove the (now long-settled) provisioning
cutover. Kept it would just be a slower, redundant re-run of a step
the surviving suites already assert on.
Test plan
bun run typecheckbun run lintbun run fmt(clean, no diff after)bun run test— 766 pass / 0 fail across all packages. The onenon-zero exit is
@intx/hub-agent(vendor/intx/hub-agent)reporting "0 test files matching" — a pre-existing vendored
package with no test files, unrelated to this change.