Repository navigation
refactor(sidecar)!: byte-for-byte copy of upstream apps/sidecar at 79adc433 - #813
Merged
Merged
Conversation
…adc433 Deletes every Workbench-only module (oauth-login, originating-workbench, hibernated-agent-identity-vault, hub-link-watchdog, workflow-deployment-record, shutdown, concurrency, boot-restore-push-hold, the workflow-host-wiring/ and workflow-substrate-factory/ split directories, step-strategy, workbench-director, and their tests) and replaces the rest with upstream's own source verbatim. The hub's CL-7508 OAuth loopback mount (createOAuthLoopbackRoutes, requestOAuthLogin, the oauthLogin gate on createSidecarRouter) is dead: the stock sidecar wires no oauthLoginExecutor into its hub link, so the hub-side gate can never get an answer. Removed from apps/hub/src/index.ts. Updates the apps/sidecar VENDORED.md row to record the byte-identical copy.
TheGreatAxios
force-pushed
the
sidecar-reset
branch
from
September 17, 2026 23:07
d28c31f to
0f0c2be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/sidecaris now a byte-for-byte copy of upstream Interchange'sapps/sidecarat79adc433: every Workbench-only module (oauth-login.ts,originating-workbench.ts,hibernated-agent-identity-vault.ts,hub-link-watchdog.ts,workflow-deployment-record.ts,shutdown.ts,concurrency.ts,boot-restore-push-hold.ts, theworkflow-host-wiring//workflow-substrate-factory/split directories,step-strategy.ts,workbench-director.ts, and their tests) is deleted; the rest is replaced with upstream's own source verbatim (tests now colocated assrc/**/*.test.ts, matching upstream).package.jsonkeeps our name (@workbench/sidecar) and license header, translates upstream's@intx/*deps toworkspace:*where vendored locally and to the sibling npm-pin convention (0.3.0) otherwise;tsconfig.json/tsconfig.src.jsonkeep our composite-build wiring with upstream's simplerinclude.@intx/*symbol the copied source imports resolves cleanly against our vendored/npm-pinned packages at the same 79adc433-aligned pin (bun run typecheckis clean repo-wide).workflow-probe-handler.test.tsthat spawn a real child process withbun --conditions=intx-src: our npm-installed@intx/logonly shipsdist/, notsrc/, so that condition can't resolve in this monorepo (upstream's own workspace shipssrc/everywhere). This is a real vendored-package gap, not a bug in the copied source — reported here rather than patched.apps/hub/src/index.ts's CL-7508 OAuth loopback wiring (createOAuthLoopbackRoutesmount,requestOAuthLogin, theoauthLogingate oncreateSidecarRouter) is dead — the stock sidecar wires nooauthLoginExecutorinto its hub link, so the hub-side gate can never get an answer (it falls back to@intx/hub-agent's fail-closed placeholder executor). Removed the mount and the gate option; leftpackages/connections'screateOAuthLoopbackRoutesexport alone since nothing else needs it touched.VENDORED.md'sapps/sidecarrow now records the byte-identical copy, nocheck:killdates(this repo has no structural check scripts anymore), kill date 2026-11-03.Test plan
bun installbun run typecheck(repo-wide)bun run lint(repo-wide; only pre-existingpreserve-caught-errorwarnings)bun run fmtbun test apps/sidecarfrom repo root — 268 pass, 0 failbun apps/sidecar/src/index.tswith no env fails onSIDECAR_DATA_DIR environment variable is required, not on import