Repository navigation
Delete the echo workflow; Myra is the only shipped workflow - #812
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflows/echois deleted;@corbits/echo-workflowdropped fromapps/hub/package.jsonandtsconfig.build.json.packages/workflows/src/catalog.tsandcatalog.test.tstrimmed to the single Myra (assistant) entry.scripts/e2e/smoke-webhook.test.tsandscripts/e2e/walking-skeleton.test.tsrewired to deploy Myra's@corbits/assistant-workflow(buildAssistantWorkflow/serializeAssistantWorkflow) instead of the echo fixture. Since Myra's definition carries realtoolPackagePins,walking-skeleton.test.ts's deploy loop now also callspublishCorbitsToolsRegistrybefore each deploy attempt, mirroring whatsmoke-webhook.test.tsalready did.workflows/README.mdandPRODUCT.md(docs/CHAT.md's "echo" mentions are about mention-handle de-duplication, unrelated to this workflow).Test plan
bun installbun run typecheckbun run lintbun run fmtbun test packages/workflows(98 pass, 1 pre-existing unrelated failure inunreachable-message-contract.test.ts— untouched by this change, a vendored-source drift check)bun test scripts/*.test.ts(70 pass, 1 skip for missingDATABASE_URL)scripts/e2e/smoke-webhook.test.ts/scripts/e2e/walking-skeleton.test.tsneedDATABASE_URLto actually run; not exercised in this environment but typecheck/lint pass against the new Myra deploy path