Repository navigation
chat-ui owns the chat wire modules; drop not-carried chat features (CL-8175) - #808
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-8175-chat-ui-wire
branch
from
September 17, 2026 22:49
5c8e658 to
eac14ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/chat-ui/src/wire/*were already self-contained copies of the browser-safe@corbits/chatmodules (no remaining@corbits/chatimports) exceptworkbench-host-naming.ts, which is deleted outright — no host runs exist after the tenancy cutover.block-responses.ts), the connect-github chat block and its onboarding-walkthrough plumbing, chat invites (invite-agent-dialog.tsx, composer mention pre-invite/"bring in" machinery), and slash commands (slash-commands.tsand the composer's/grammar, help popover, and/summarizemacro).packages/chat-ui/src/blocks/registry.tsxnow only routesapprove,steps,metrics,stream, andconnect-serviceblock kinds.packages/chat-ui/src/mentions.tsdown to plain@mentionautocomplete (keptactiveMentionQuery,filterMentionCandidates,insertMention,mentionCandidatesFromParticipants); the "bring-in" invite-picker half is gone.apps/web/src/insights-stats.ts'spurposeRunsForInsightsno longer importsisWorkbenchHostDefinitionName(module deleted) — it's now an identity pass since no workbench-host runs exist post-cutover.apps/web/src/block-response-actions.ts(only consumer of the removed block-response wire) and its usage inchat-page.tsx.@corbits/chat/@corbits/commands/@corbits/agent-runtime/@corbits/turn-artifactsimports acrosschat-ui,settings-ui,notify,evals, andapps/webwere already clean before this PR (a prior PR had done that half of the cutover); this PR's job was the wire-module ownership and not-carried-feature deletion.Verification
git grep -n "@corbits/chat\b\|@corbits/chat/\|@corbits/commands\|@corbits/agent-runtime\|@corbits/turn-artifacts" apps/web packages/chat-ui packages/settings-ui packages/notify packages/evalsreturns only README/comment prose (no live imports).bun run typecheck(repo-wide),bun run lint,bun run fmt:checkall pass.bun testinpackages/chat-ui,packages/settings-ui,apps/weball green (656 / 157 / 768 pass respectively).scripts/ci-jobs.test.tshas 3 pre-existing failures (CI job-list expectations) reproducible onorigin/mainbefore this change — unrelated to this PR, left as-is.packages/notifytypecheck shows pre-existingvendor/intxstale-build (TS6305) errors unrelated to this change (vendor dist not rebuilt in this worktree).Test plan
bun run typecheckbun run lintbun run fmt:checkbun testin chat-ui, settings-ui, apps/web