Repository navigation
Delete hub-side onboarding seed (CL-8207) - #804
Merged
Merged
Conversation
The hub never seeds (client-drives-converge, 2026-09-17): apps/web already mints its own tenant, connects a provider, and deploys Myra as a converge loop over stock routes. @workbench/onboarding — its route, its first-login provisioning hook, its pending-seed background drain, its onboarding Postgres schema — existed only to feed that dead path. Deletes the package outright. The one still-legitimate use of its tenant-seed/credential-connect machinery — standing up a fully deployed tenant for an e2e/eval harness without driving a browser — moves to packages/connections (tenant-seed.ts, complete-credential.ts), the package that already owns credential-connect. desired-state.ts's reconcile machinery and the whole genesis/provision/pending-seed/ bench-provisioning stack had no callers left outside the deleted route and are dropped rather than moved. connections' own dead onInferenceCredentialUsable seam (a hook nothing ever wired) goes too. scripts/e2e/browser/walkthrough.ts now drives the real onboarding-page UI form to connect a provider instead of calling package internals directly. scripts/e2e/local-rip.test.ts, which proved the same path by calling those internals, is deleted in favor of that real UI proof.
Owner ruling: hub never seeds, so this machinery doesn't get a new home
in packages/connections either — it gets deleted outright.
- packages/connections/src/{tenant-seed,complete-credential}.ts: removed,
along with the subpath exports and the workflow-package/@intx/agent/
@intx/hub-common deps they alone needed.
- scripts/e2e/{chat,greeting-delivery}.test.ts, play.ts,
cl-6324-launch-proof.ts, cl-6329-turn-swap-proof.ts,
cl-6451-single-run-proof.ts: deleted — chat-era proofs whose only job
was driving seedTenant/testAndPersistCredential directly.
- packages/evals/src/targets/real-target.ts (+ its test) and
scripts/evals-run.ts (bun run eval): deleted — bootMyraTarget's only
path to a working bench was completeCredentialSetup, and it was the
only Target this eval harness had, so the whole bun-run-eval surface
goes with it rather than half-working.
- DEFAULT_WORKFLOWS/CATALOG_WORKFLOWS: no literal to relocate — with
every caller above gone, nothing needs the list any more.
packages/workflows/src/catalog.ts already carries the durable
assetName/displayName/automatable metadata for the same workflows,
read from each package's own corbits.workflow block.
Stale comments in packages/connections/src/{routes,seed-catalog}.ts,
packages/hub-api-client/src/errors.ts, apps/web/src/myra-workbench.ts,
and workflows/{README.md,heartbeat,workbench-digest}/src updated to stop
pointing at the deleted files.
TheGreatAxios
force-pushed
the
cl-8207-client-start
branch
from
September 17, 2026 22:36
5a9232b to
0c08171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@workbench/onboardingoutright: the hub never seeds (client-drives-converge ruling) —apps/webalready mints its own tenant, connects a provider, and deploys Myra over stock routes with no hub-side route or first-login hook feeding it.onboardingPostgres schema/migrations, thepending_seedbackground drain (bench-provisioning.ts), thegenesis/provisionfirst-login decision,desired-state.ts's reconcile machinery — none had a caller left outside the deleted route.packages/connectionsgainstenant-seed.tsandcomplete-credential.ts: the still-legitimate use of this machinery is standing up a fully deployed tenant for e2e/eval harnesses (packages/evals' real-target,scripts/e2e/{chat,greeting-delivery,play,cl-6324,cl-6329,cl-6451}*) without driving a browser — connections already owns credential-connect, so this is where it belongs now.packages/connections' ownonInferenceCredentialUsableseam (a hook nothing ever wired, existing only to feed the deleted pending-seed drain) is deleted along with its dead code path inroutes.tsand its tests.scripts/e2e/browser/walkthrough.tsnow drives the real onboarding-page UI form (radiogroup + password input + submit) to connect a stub provider, instead of callingtestAndPersistCredential/ensureSeededdirectly.scripts/e2e/local-rip.test.ts, which proved the same path by calling those internals directly, is deleted —walkthrough.ts's real-browser proof now covers it.scripts/db-setup.tsno longer applies onboarding migrations or lists its schema; per owner ruling this is a hard breaking cutover, not a forward-drop migration.What used to be seeded that now happens nowhere
createOnboardingRoutesand no composition wiresonInferenceCredentialUsable. The web client's own converge loop (apps/web/src/needs-converge.ts,client-bootstrap.ts,pages/onboarding-page.tsx) is the sole live path and is untouched by this PR.Test plan
bun run typecheck— passesbun run lint— passesbun run fmt:check— passesbun run test(root, per-package) — passes except 3 pre-existing failing packages unrelated to this change (@intx/hub-agent,@corbits/webhook-triggers,@corbits/workflows— none touched by this diff) and@corbits/chat(14 fails, only a one-line comment touched here; another concurrent PR is cutting chat out of the hub)packages/connections,packages/evals,packages/inbox,packages/hub-api-clientpackage tests pass directlybun run check:structuralintentionally skipped per owner note (scripts/checks is being deleted on main in a concurrent PR)