Repository navigation
chat-ui: composer sends through POST /me/inbox/send (CL-8175) - #798
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-8175-composer-send
branch
from
September 17, 2026 21:49
1527af3 to
5b8f3d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@corbits/mailbox'sPOST /me/inbox/send({ to, body, inReplyTo? }) instead of the legacy@corbits/chatmessage route — matching the reads, which already moved onto the mailbox in CL-8174.tois every other participant's mailbox address (Workbench.participants, minus the signed-in sender by principal-id local part).inReplyTois the RFCMessage-IDof the thread root (or the specific message being replied to when starting a fresh thread) — resolved from the loaded feed's own messages, sinceopenThreadId/pendingParentMessageIdare mailbox uids, not wire ids.sendMessageclient, itsSendMessageOptions/MessageInviteInputtypes, and the now-unusedSentMessageschema; addedsendInboxMessagein their place.instant-agent-create.ts's opening-message send (new-workbench picker) moved onto the same call: it now invites each selected agent first (inviteAgent, which returns the agent's own address) and sends the opening message to those addresses.MessageItemgained an optionalmessageId(the RFCMessage-ID), populated bymailbox-timeline.tsfor every mail-derived row.Known gaps (left for follow-up, not moved off the old route)
inviteonMessageSendOptions): the chat route resolved "Bring in…" mention picks server-side before the send; the mailbox route has no such concept, so that fan-out is gone from the composer's own send path. Inviting an agent explicitly (Settings → Agents //invite) still works.instant-agent-create.ts's opening message is only sent when at least one agent was selected — mail requires a non-emptyto, so an opening message typed with zero agents picked is no longer attempted (previously it posted into an ownerless empty room).Test plan
bun run typecheck— clean outsidepackages/chat-ui/**/*.test.*(another agent is deleting/rewriting those in parallel per the dispatch instructions; two pre-existing test files there now fail to compile against the deletedsendMessageexport and the newuseOptimisticSendsargs)bun run lintbun run fmtbun testinapps/web— 768 pass, 3 pre-existing unrelated Tailwind-CSS failuresbun testinpackages/chat-ui— failures are confined topackages/chat-ui/**/*.test.*files (out of scope per dispatch instructions)