Repository navigation
workflows: heartbeat, workbench-digest, credential-expiry are mail-triggered (CL-8183) - #797
Merged
Merged
Conversation
…iggered (CL-8183)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type: "schedule"triggers atdefineWorkflowand at the hub probe gate.@corbits/cronwill deliver a tick mail on each schedule instead, so every workflow that used to declare a schedule trigger becomes mail-triggered.heartbeatwas already mail-triggered ({ type: "mail", to: input.triggerAddress }) — no change needed there.workbench-digestandcredential-expirynow take atriggerAddressinput and declare{ type: "mail", to: input.triggerAddress }, following the same convention asecho/heartbeat/code-review. Removed the now-unusedWORKBENCH_DIGEST_SCHEDULE_CRON/CREDENTIAL_EXPIRY_SCHEDULE_CRONexports.buildWorkbenchDigestWorkflow(packages/onboarding/src/tenant-seed.ts, catalog workflow entry) and the digest e2e script to pass atriggerAddress;credential-expiryhas no wiring yet so nothing else to update.workflows/workbench-digest/test/definition.test.tsand replaced it with a mail-trigger assertion (mirroring heartbeat's), plus an empty-triggerAddress rejection test.Test plan
bun test workflows/heartbeat workflows/workbench-digest workflows/credential-expiry— 27 passbun test packages/onboarding— 212 pass, 12 DB-gated skips (no localDATABASE_URL, expected)bun run typecheck && bun run lint && bun run fmt— cleanbun run check:structural— all checks ok (no version bump required by tool-package-freshness)