Repository navigation
Delete chat-ui feed tests retired by the mail-thread cutover (CL-8150) - #796
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #795 moved the chat feed adapter to native
GET /me/inbox/threads, retiring the/me/threads?refs=route and the old chat-send shape. This left 34 chat-ui DOM test cases failing because their fixtures mocked the retired route/shape. Per owner ruling, these are deleted outright rather than patched to keep passing.Deleted:
packages/chat-ui/test/stream-message-parse-drop.test.tsxpackages/chat-ui/test/zero-refetch-on-stream-event.test.tsxdescribeblocks frompackages/chat-ui/test/chat-workspace.test.tsx(file kept, since two of its describe blocks still pass against the current route/shape and were left in place):ChatWorkspace settings surfaceconnection state is never rendered as chromeThread breadcrumb and fork (CL-5908, CL-5948)hover Edit copies an own prompt into the composercomposer slash commands — each wired command's real actiona workbench-level 404 offers a way out instead of retrying forevera 401 on the messages load offers Sign in instead of a dead-end retryoptimistic send (CL-6103)refresh ordering around a send (CL-6251, CL-6313)Workbench header polish (CL-6106)CL-6833: running-turn resume failure is visible, never silent idleswitching workbenches never carries a stale root-thread id acrossKept (still green, unrelated to the retired route):
chat error copy never leaks a raw API path,Invite control visibility (CL-6781).Recorded on CL-8150 for selective rebuild against the new mailbox-thread shape.
Test plan
bun testinpackages/chat-ui: 802 pass, 0 failbun run typecheckat repo root: cleanbun run lintat repo root: clean