Repository navigation
feat(hub)!: drop the setup-status and noop-inference mounts (CL-8160) - #786
Merged
Merged
Conversation
The hub no longer mounts /api/setup (setup-status.ts) or /api/chat/noop-inference (e2e/noop-inference.ts): a scheduled step that needs no model must not call one, and setup status is now derived client-side from the converge state (findOwnedTenants over createFetchStockHub) instead of a hub-served route. - apps/web/src/onboarding.ts's triggerFirstLoginProvisioning now reads ownership of tenants directly over stock routes instead of GET /api/setup/status. - packages/connections/src/seed-catalog.ts drops ensureNoopCatalogOffering and its NOOP_* constants; its underlying ensureCatalogModel/Provider/Offering primitives are now exported for reuse. packages/onboarding/src/tenant-seed.ts drops the dead noop-pinned-workflow branch (modelSource) it fed — no seeded workflow set that field. - workflows/heartbeat and workflows/workbench-digest stop documenting a deployer-side noop ModelSource pin: with no non-agent step primitive wired on the deployed host (@intx/workflow's `action` primitive has no invokeAction callback anywhere), these now deploy against the tenant's own real, resolved catalog offering like every other workflow, per owner decision. - E2E suites that exercised the noop path (scripts/e2e/heartbeat.test.ts, workbench-digest.test.ts, smoke-webhook.test.ts) now start their own local noop inference server (scripts/e2e/noop-inference-server.ts, moved handler) and plant a catalog offering against it directly, never against the hub. Deleted tests (hard cutover, encoded the removed hub routes): - apps/hub/src/setup-status.test.ts - apps/hub/src/e2e/noop-inference.test.ts - apps/web/test/onboarding.test.tsx - the "ensureNoopCatalogOffering" describe block in packages/connections/src/seed-catalog.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/setupmount (apps/hub/src/setup-status.ts):apps/web/src/onboarding.ts'striggerFirstLoginProvisioningnow derives setup-required from the client converge state (findOwnedTenantsovercreateFetchStockHub) instead of a hub-served route./api/chat/noop-inferencemount and module (apps/hub/src/e2e/noop-inference.ts) — owner decision: a scheduled step that needs no model must not call one.packages/connections/src/seed-catalog.tsdropsensureNoopCatalogOfferingand itsNOOP_*constants; the underlyingensureCatalogModel/ensureCatalogProvider/ensureCatalogOfferingprimitives are now exported for reuse.packages/onboarding/src/tenant-seed.tsdrops the dead noop-pinned-workflow branch (modelSource) it fed — no seeded workflow set that field, so this was already dead code (heartbeat was previously dropped from the seeded set).workflows/heartbeatandworkflows/workbench-digestno longer document a deployer-side noopModelSourcepin.@intx/workflow'sactionprimitive (the only non-agent step shape) has noinvokeActioncallback wired on any shipped host, so per owner direction these now deploy against the tenant's own real, resolved catalog offering like every other workflow, rather than inventing a fake provider to route around a step that will still make a real call.scripts/e2e/heartbeat.test.ts,workbench-digest.test.ts,smoke-webhook.test.ts) now start their own local noop inference server (newscripts/e2e/noop-inference-server.ts, handler moved from the deleted hub module) and plant a catalog offering against it directly — never against the hub.Deleted tests (hard cutover — encoded the removed hub routes)
apps/hub/src/setup-status.test.tsapps/hub/src/e2e/noop-inference.test.tsapps/web/test/onboarding.test.tsx"ensureNoopCatalogOffering"describeblock inpackages/connections/src/seed-catalog.test.tsTest plan
bun run typecheckbun run lint(pre-existingAGENTS.mdprettier warning onmain, untouched by this branch, left as-is)bun run check:structural(regeneratedreport-errorbaseline for the one stale entry this change fixed)bun --cwd apps/hub testbun --cwd apps/web test