Repository navigation
feat(hub)!: artifacts ride on @corbits/artifacts; drop artifacts-hub (CL-8188) - #785
Merged
Merged
Conversation
…-8188) Point every workflow-artifacts client mock and memory-hub's own test import at the shapes @corbits/artifacts' mountWorkflowArtifacts/mountArtifacts actually serve, ahead of the implementation swap.
…(CL-8188) Bump every @corbits/artifacts pin to 348c26e (v0.2.0), which now covers the whole artifacts-hub HTTP surface natively: counts, preview, and mountWorkflowArtifacts' run-scoped create/recent/get/binary routes. apps/hub mounts @corbits/artifacts' mountArtifacts directly on the tenant prefix (countSegments built from @corbits/artifact-ui's LIBRARY_KIND_SEGMENTS) and mountWorkflowArtifacts at /api/workflow-artifacts, resolving run scope through the authenticator apps/hub/src/workflow-run-tenant-auth.ts already owned. packages/artifacts-hub is deleted; the generic sidecar-token + run-address authenticator it used to own moves into that same workflow-run-tenant-auth.ts, and packages/memory-hub declares its own local structural WorkflowRunAuthenticator/ResolvedWorkflowRunScope types (matching the convention every other workflow-run-authenticated package already follows) instead of importing the retired package's concrete ones. mountWorkflowArtifacts' fixed route shape (POST/GET .../artifacts, .../recent, .../binary) puts every route one segment deeper than the old ad hoc mount, so every workflow-artifacts client (scout-agent, and each Routine's own duplicated artifact-client.ts) now calls /api/workflow-artifacts/artifacts... instead of /api/workflow-artifacts/. The tenant Library surface's wire envelope also changed (list responses key rows under "artifacts" not "data"; single-artifact reads wrap the row under "artifact"); apps/web's api.ts schemas and the Files page/upload helper/command palette follow. packages/turn-artifacts is kept: it never actually depended on artifacts-hub (only mentioned it in comments). Known issue: @corbits/artifacts348c26e's own src (artifacts.ts, counts.ts) fails this repo's `exactOptionalPropertyTypes: true` typecheck in three places — genuine bugs in the pinned commit, surfaced because the package ships no build step / dist and resolves to raw src under bun. Needs a fix upstream in corbits-artifacts before `bun run typecheck` is fully green.
…CL-8188) Regenerated via bun run check:structural report-error -- --write-baseline after packages/artifacts-hub's three baselined catch clauses left with it.
TheGreatAxios
force-pushed
the
cl-8188-artifacts-library
branch
from
September 17, 2026 19:18
bbc7e3e to
fc9363f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@corbits/artifactspin to348c26e6f78b068c571662870e11b607e5f61a0b(v0.2.0), which now covers the whole artifacts-hub HTTP surface natively:GET /artifacts/counts,GET /artifacts/:id/preview, andmountWorkflowArtifacts' run-scoped create/recent/get/binary routes.apps/hubmountsmountArtifactsdirectly on the tenant prefix (countSegmentsbuilt from@corbits/artifact-ui'sLIBRARY_KIND_SEGMENTS) andmountWorkflowArtifactsat/api/workflow-artifacts, resolving run scope through the authenticatorapps/hub/src/workflow-run-tenant-auth.tsalready owns (the generic sidecar-token + run-address authenticator that used to live inpackages/artifacts-hubmoved there).packages/artifacts-hubentirely.packages/turn-artifactsis kept — it never actually depended on artifacts-hub (only mentioned it in comments).mountWorkflowArtifacts' fixed route shape (POST/GET .../artifacts,.../recent,.../binary) puts every route one segment deeper than the old ad hoc mount, so every workflow-artifacts client (scout-agent, and each Routine's own duplicatedartifact-client.ts) now calls/api/workflow-artifacts/artifacts...instead of/api/workflow-artifacts/."artifacts", not"data"; single-artifact reads wrap the row under"artifact");apps/web'sapi.tsschemas, the Files page, the upload helper, and the command palette follow.packages/scout-agentbumped to0.0.4(tool-package-freshness) with its pin updated inpackages/scout-agent/src/definition.ts.Known issue (not fixed here)
@corbits/artifacts@348c26e's ownsrc/artifacts.tsandsrc/counts.tsfail this repo'sexactOptionalPropertyTypes: truetypecheck in three places — genuine bugs in the pinned commit, surfaced only because the package ships no build step /distand resolves to rawsrcunder thebuncondition.bun run typecheckis not fully green until this is fixed upstream incorbits-artifactsand re-pinned.Test plan
bun run lint— clean (one pre-existing, unrelatedAGENTS.mdprettier warning present onmainbefore this change)bun run check:structural— all checks passbun --cwd apps/hub test— 167 pass, 0 fail (DB-gated suites skip locally per repo convention)bun --cwd apps/web test— 799 pass, 0 failbun run typecheck— blocked on the upstream@corbits/artifactsdefect above; no errors from this repo's own code