Repository navigation
feat(hub)!: catalog blocks derive client-side from stock definitions; drop the route (CL-8160) - #784
Merged
Merged
Conversation
The hub mounts only stock routes plus Corbits libraries; the on-demand catalog-block deploy route (POST /api/tenants/:tenantId/catalog-blocks/ :assetName/deploy) built workflow JSON from workflow packages and wrote an asset directly from apps/hub, which is hub-local product logic the owner ruling forbids. Deletes apps/hub/src/catalog-blocks/* (module, routes, and their tests) and the mount + its inline deployWorkflowSource/workflowDeployer wiring in apps/hub/src/index.ts. The Available section's on-demand Add action has no stock replacement yet, so it is removed along with the client's deployCatalogBlock call; the section is read-only until a deploy path lands on stock rails. The separate GET /workflows/available listing (packages/workflows) is untouched. Deleted tests: - apps/hub/src/catalog-blocks/catalog-block-routes.test.ts - apps/hub/src/catalog-blocks/catalog-blocks.test.ts - apps/web/test/routines-available-section.test.tsx: "Add posts to the catalog-blocks deploy route and the entry disappears from Available" (route deleted); the disabled-Add-button assertions in the missing- connection test were folded into a read-only reason+link check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@intx/hub-apiroutes plus a fixed set of Corbits libraries; the on-demand catalog-block deploy mount (POST /api/tenants/:tenantId/catalog-blocks/:assetName/deploy) was hub-local product logic building workflow JSON fromworkflows/*packages and writing an asset directly fromapps/hub, which the ruling forbids.apps/hub/src/catalog-blocks/*(module, routes, tests) and the mount plus its inlinedeployWorkflowSource/workflowDeployerwiring inapps/hub/src/index.ts.deployCatalogBlockclient call are removed; the section stays a read-only list until a deploy path lands on stock rails. The separateGET /workflows/availablelisting (packages/workflows) already derives its display data from stock reads and is untouched.scripts/checks/no-product-tenancy.tsallowlist entries were owned by this module, so nothing to forward-drop there.Deleted tests
apps/hub/src/catalog-blocks/catalog-block-routes.test.ts— route deletedapps/hub/src/catalog-blocks/catalog-blocks.test.ts— module deletedapps/web/test/routines-available-section.test.tsx: "Add posts to the catalog-blocks deploy route and the entry disappears from Available" — deploy route deleted, no replacement in this slice. The disabled-Add-button assertions in the missing-connection test were folded into a read-only reason+link check.Test plan
bun run typecheckbun run lintbun run check:structuralbun --cwd apps/hub test(156 pass, DB-gated suites skip locally per AGENTS.md)bun --cwd apps/web test(798 pass)