Repository navigation
feat!: memory rides on @corbits/memory; drop memory-hub and memory-tools (CL-8186) - #781
Merged
Merged
Conversation
CL-8186: the memory plane was dark — nothing constructed @corbits/memory and memory-hub was never mounted. Cuts over fully: - Delete packages/memory-hub and packages/memory-tools entirely (they duplicated a workflow-run-authenticated HTTP surface @corbits/memory now serves directly on the stock /api/tenants/:tenantId/memory/* routes). - apps/hub/src/index.ts constructs @corbits/memory once via loadMemoryConfig() and mounts it next to @corbits/mailbox, guarded by the hub's own requireGrant. - Myra (workflows/assistant) and Scout (packages/scout-agent) and diligence-brief now pin @corbits/memory instead of @corbits/memory-tools. Since @corbits/memory is a published dependency rather than a workspace-built tool package, the tool-package-pins check now also resolves a pin against an installed (non-workspace:*) @corbits dependency's own package.json version. - apps/sidecar's step-env wires memoryBaseUrl/memoryTenantId/ memoryAuthToken/memoryFetch for @corbits/memory/tools, reusing the same sidecar-token + run-address bearer scheme every other workflow-run-authenticated tool bundle uses (memoryFetch injects the x-workflow-run-address header @corbits/memory's own HTTP client doesn't send). - packages/onboarding's tenant-seed SEED_GRANTS gains {resource: "memory", action: "add"} and {resource: "memory", action: "search"} (list reuses the search grant) for the tenant's shared workflow principal — @corbits/memory's own grant vocabulary (see its routes/deps.ts grantGuard). - REQUIRED_SEED_TOOL_PACKAGES / CORBITS_TOOL_PACKAGE_DIRS in tool-registry-publish now name @corbits/capability-tools instead of the deleted @corbits/memory-tools, since @corbits/memory is not a workspace package this repo packs into the corbits-tools registry. Deleted tests: packages/memory-hub/src/workflow-routes.test.ts and packages/memory-tools/src/{client,tool}.test.ts went with their packages. Every other touched test file was adapted (fixture rename or behavior-consistent update), not deleted.
TheGreatAxios
force-pushed
the
cl-8186-drop-memory-hub
branch
from
September 17, 2026 18:54
3598604 to
cb0fd2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CL-8186: the memory plane was dark — nothing constructed
@corbits/memoryand memory-hub was never mounted. This cuts over fully onto@corbits/memory(already a pinned git dependency elsewhere in this repo) and deletes the two workbench-built packages it replaces.packages/memory-hubandpackages/memory-toolsentirely.apps/hub/src/index.tsconstructs@corbits/memoryonce vialoadMemoryConfig()and mounts its stock/api/tenants/:tenantId/memory/*routes next to@corbits/mailbox, guarded by the hub's ownrequireGrant.workflows/assistant), Scout (packages/scout-agent), andworkflows/diligence-briefnow pin@corbits/memoryinstead of@corbits/memory-tools.scripts/checks/tool-package-pins.tsnow also resolves a pin against an installed (non-workspace:*)@corbits/*dependency's ownpackage.jsonversion, since@corbits/memoryis a published dependency, not a workspace-built tool package.apps/sidecar's step-env wiresmemoryBaseUrl/memoryTenantId/memoryAuthToken/memoryFetchfor@corbits/memory/tools, reusing the same sidecar-token + run-address bearer scheme every other workflow-run-authenticated tool bundle uses (memoryFetchinjects thex-workflow-run-addressheader@corbits/memory's own HTTP client doesn't send on its own).packages/onboarding'stenant-seed.tsSEED_GRANTSgains{resource: "memory", action: "add"}and{resource: "memory", action: "search"}(list reuses the search grant) for the tenant's shared workflow principal, matching@corbits/memory's own grant vocabulary (itsroutes/deps.tsgrantGuard). Note: the ticket namedapps/web/src/needs-converge.ts/needs-list.tsfor this, but those files only carry role names resolved server-side — the actual grant-planting site ispackages/onboarding/src/tenant-seed.ts'sSEED_GRANTS, so that's where this landed.REQUIRED_SEED_TOOL_PACKAGES/CORBITS_TOOL_PACKAGE_DIRSintool-registry-publishnow name@corbits/capability-toolsinstead of the deleted@corbits/memory-tools, since@corbits/memoryis not a workspace package this repo packs into thecorbits-toolsregistry.Deleted tests
packages/memory-hub/src/workflow-routes.test.tspackages/memory-tools/src/client.test.tspackages/memory-tools/src/tool.test.ts(deleted with their packages — everything else touched was adapted, not deleted, since it tested still-valid generic behavior with
memory-toolsas an arbitrary fixture name)Test plan
bun run typecheckbun run lintbun run check:structuralbun --cwd apps/hub test(DB-gated suites skip locally, noDATABASE_URL)bun --cwd apps/web test