Repository navigation
feat!: remove presence; artifact editing is single-user until @corbits/presence returns (CL-8189) - #779
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-8189-remove-presence
branch
from
September 17, 2026 18:50
5a7a88f to
b4d47f9
Compare
…s (CL-8189) Presence (packages/presence) is removed from Workbench and preserved upstream at corbitsdev/corbits-presence. Deleted tests: every test that exercised @corbits/presence, Y.Doc co-editing, or the cursor overlay — they encode behavior that no longer exists, not behavior to keep passing.
Presence (who's-here, cursors, typing, Y.Doc co-editing) is dropped from Workbench entirely for now; the library is preserved at corbitsdev/corbits-presence for whenever it returns. It was only used by the artifact co-edit surface. The artifact editor becomes a plain controlled textarea, debounced-saved through a new PUT /api/tenants/:id/artifacts/:artifactId route (added to packages/artifacts-hub, using @corbits/artifacts' existing writeArtifactVersion) — the only save path before this was presence's Y.Doc snapshot persistence, which never had an HTTP equivalent. Removes the hub's presence room registry/routes mount, apps/web's presence client and cursor overlay, the yjs/y-protocols dependency, and @corbits/presence from every consuming package.json.
Regenerate .changeset/config.json and tsconfig.build.json for the deleted packages/presence workspace; shrink the report-error baseline for the deleted catch clauses; drop docs/presence.md; settle bun.lock.
TheGreatAxios
force-pushed
the
cl-8189-remove-presence
branch
from
September 17, 2026 18:51
b4d47f9 to
9a71040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArtifactTextEditor), debounced-saved through a newPUT /api/tenants/:tenantId/artifacts/:artifactIdroute added topackages/artifacts-hub(uses@corbits/artifacts' existingwriteArtifactVersion) — this is the only save path a doc-kind artifact ever gets now. Previously the only save path was presence's Y.Doc debounced snapshot persistence, which had no HTTP equivalent.packages/presenceentirely, the hub's presence room registry/mount inapps/hub/src/index.ts,apps/web/src/presence/, and every@corbits/presence/yjs/y-protocolsdependency..changeset/config.json; shrank thereport-errorbaseline for the deleted catch clauses.Deleted tests
Per owner ruling, tests encoding the old co-edit/presence behavior were deleted rather than adapted:
apps/hub/test/artifact-doc-persistence.test.ts(presence → writeArtifactVersion wiring)apps/hub/test/presence-mount.test.tsapps/web/test/use-presence-room.test.tsxapps/web/test/artifact-cursor-overlay.test.tsxpackages/artifact-ui/test/artifact-text-editor.test.tsx(Y.Doc-based)packages/artifact-ui/src/y-text-diff.test.ts(and its source,y-text-diff.ts)packages/presence/**(whole package, tests included)apps/web/test/canvas-column.test.tsx— replaced with a single-user equivalent covering the same read-only/editable/typing-saves behavior.save-state.test.ts's "editing" (co-editor) cases — theeditingArtifactSaveStatekind is gone, replaced bysaving.What the artifact editor save path is now
ArtifactTextEditor(packages/artifact-ui) is a plain controlled<textarea>. On change it debounces 1s then callsonSave(content). The host (apps/web/src/shell/app-shell.tsx) wires that tosaveArtifactContent(apps/web/src/shell/library-artifacts.ts), which doesPUT /api/tenants/:tenantId/artifacts/:artifactIdwith{ content }. That route (new, inpackages/artifacts-hub/src/routes.ts) calls@corbits/artifacts'writeArtifactVersionand returns the updated row; the host renders "Saving…" / "Saved · vN" / "Unsaved changes" off the response.Test plan
bun run typecheckbun run lintbun run check:structuralbun --cwd apps/hub test(DB-gated suites skip locally, no DATABASE_URL)bun --cwd apps/web testbun --cwd packages/artifact-ui test