Repository navigation
feat(hub)!: delete the eval-runs mount (CL-8160) - #774
Merged
Merged
Conversation
The Myra evals harness (`packages/evals`) is a dev/CI tool driven by
`bun run eval` and the package's own tests, not a product surface — the
hub's `${TENANT_PREFIX}/eval-runs` route and the web Evals page had no
consumer beyond a sidebar nav item gated on the route ever returning
data. Delete the hub mount, `createEvalRunRoutes`/`routes.ts`, and the
web evals-api/evals-page/sidebar surface. `packages/evals` keeps its
`EvalRunStore`/`evals.run` table and migrations, since `bun run eval`
still persists live runs there for history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CL-8160 owner ruling: the hub mounts nothing Workbench-specific; everything product-shaped is a workflow package. Scoped to the eval-runs surface only.
Choice made: keep
packages/evalsas a private dev/CI tool, delete only the product HTTP surface.packages/evalsis Myra's evals harness — driven bybun run evaland covered by its own package tests, playing a hardcoded scripted scenario against a real hub+sidecar. It is not product-facing: the only consumer of the hub's${TENANT_PREFIX}/eval-runsmount was the web sidebar's own conditional nav item (query it, then only show "Evals" if it ever returned rows) and the standalone/evalspage — no other package or workflow reads it.Deleted:
apps/hub/src/index.ts: the${TENANT_PREFIX}/eval-runsmount, its migration/store wiring, and the@corbits/evalsdependency inapps/hub/package.json(nothing else in the hub used the package)packages/evals/src/routes.ts(+ its test) and thecreateEvalRunRoutesexport — the package'shono/@intx/hub-apideps went with itapps/web/src/evals-api.ts,evals-path.ts,pages/evals-page.tsx, and the sidebar's Evals nav item/query, plus their testsKept:
packages/evals'sEvalRunStore,evals.runtable, and migrations —scripts/evals-run.ts(bun run eval) still persists live runs there for history, so the table has a real writer independent of the hub route.scripts/checks/no-product-tenancy.ts's allowlist entry forevals.runis unchanged since the table itself wasn't touched.Test plan
bun run typecheckbun run lintbun run check:structuralbun --cwd apps/web test(869 pass)