Repository navigation
feat(hub)!: delete bench-settings mount; settings live in tenant config (CL-8160) - #769
Merged
Merged
Conversation
`${TENANT_PREFIX}/bench-settings` served a bench's purpose/type out of a
package-owned `bench.bench_settings` side-table. Nothing read it: the
package shipped a browser client (`getBenchSettings`/`patchBenchSettings`)
that no app or package ever imported, and the chat package's
similarly-named `getBenchSettings` is its own unrelated store. So there is
nothing to move into stock tenant `config` — the surface is deleted
outright.
Gone with it: the route, the store, the migration, and the `bench` schema,
which `db-setup` now drops forward-only alongside the CL-8158 dead mounts.
The reset path still lists `bench` among the package schemas so a leftover
deployment is cleaned on the next reset.
TheGreatAxios
force-pushed
the
cl-8160-reads
branch
from
September 17, 2026 18:05
d572708 to
27a5011
Compare
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
${TENANT_PREFIX}/bench-settingsand the@corbits/benchpackageoutright: the route, the
bench.bench_settingsstore, its migration, andthe
benchPostgres schema.db-setupnow drops that schema forward-onlyalongside the CL-8158 dead mounts, and the reset path still lists
benchamong the package schemas so a leftover deployment is cleaned on the next
reset.
Where the settings moved
Nowhere — there was nothing to move. The package shipped a browser client
(
getBenchSettings/patchBenchSettings) that no app or package everimported, and the similarly-named
getBenchSettingsin the chat package isits own unrelated store. The surface was dead, so it's deleted rather than
folded into stock tenant
config.Test plan
bun run typecheckbun run lintbun run check:structuralbun --cwd apps/web test