Repository navigation
feat(packages): publishable error-sink, connector registry, code-review; all tool packages public (CL-8166) - #766
Merged
Merged
Conversation
Drop private, add the publishable shape (files, repository, publishConfig.access: public) and move @intx/log to a peerDependency — error-sink was already generic (redaction + refId + context envelope, no Workbench-private runtime dep), it just hadn't been flipped. This is what CL-8166 unblocks access-tools and interaction-tools going public. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@corbits/connections is a private, hub-only library (OAuth exchange, credential probing, routes) — connections-tools only ever read a handful of fields off its ConnectorRegistry/McpPreset shapes (the caller wires its own registry into the tool's env; this package never carried a connector set of its own). Fold the minimal field shapes and the one lookup helper (mcpPresetByName) into a small local module (src/registry-shape.ts) instead of standing up a whole new package for a few structural types — the deploying build's richer descriptor/preset objects still satisfy them structurally. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
Its only runtime dep is @corbits/github-tools, already public — flip private, add the publishable shape, and move github-tools to a peerDependency. Smaller diff than folding its ten modules into workflows/code-review, and packages/connections and packages/scout-agent also depend on it directly. Bump the workflow's own dependency pin to match. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
…public Now that error-sink is publishable and connections-tools carries no private runtime dep, apply the same shape to all three (files, repository, publishConfig.access: public, workspace:* deps moved to peerDependencies) and bump each a patch version. Update the pin literals in workflows/assistant/src/prompt.ts to match. Every tool package under packages/*-tools is now publishable with no exemption. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
bun run scripts/generate-tsconfig-references.ts and check:structural report-error --write-baseline after the peerDependency moves above — tsconfig project references track package.json dependencies, and the report-error baseline only shrinks (connections-tools/src/tool.ts's entry moved location). Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@corbits/error-sinkis now publishable: it was already generic(redaction + refId + context envelope over
@intx/log), just neededthe publishable shape and
@intx/logmoved to a peerDependency.@corbits/connections-toolsdrops its@corbits/connectionsruntimedependency. It never carried a connector set of its own — the caller
wires its own registry/preset list into the tool's env — so the
handful of fields it actually reads plus the one lookup helper
(
mcpPresetByName) now live in a small local module(
src/registry-shape.ts) rather than a new package; the deployingbuild's richer descriptor/preset objects still satisfy the shape
structurally.
@corbits/code-reviewis now publishable rather than folding itsmodules into
workflows/code-review: its only runtime dep is thealready-public
@corbits/github-tools, andpackages/connections/packages/scout-agentalso depend on it directly, so this was thesmaller diff with no private runtime edge left.
access-tools,interaction-tools, andconnections-toolsflippublic with the same shape (files/repository/publishConfig,
@intx/*and
@corbits/*deps moved to peerDependencies), each bumped a patchversion, with the
{ name, version }pin literals inworkflows/assistant/src/prompt.tsupdated to match.baseline (a stale entry, no new violations) after the dependency
moves above.
Every package under
packages/*-toolsis now publishable with noexemption;
check:publishable-workflowscovers all 17 tool packages.Test plan
bun run typecheck(pre-existing, unrelated failure inpackages/chat-uitest files — not touched by this branch)bun run lintbun run check:structural(all green)bun testin every touched package (error-sink, access-tools,interaction-tools, connections-tools, code-review,
workflows/code-review)
bun pm packfor@corbits/access-tools, extracted,@intx/*peers installed from the real npm registry, and an import proof
against the extracted tarball (with a stub
@corbits/error-sink,since that package isn't published yet — CL-8167's job)
https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG