Skip to content

feat!: delete templates/ and template block routes (CL-8156) - #762

Merged
TheGreatAxios merged 8 commits into
mainfrom
cl-8156-delete-templates
Sep 17, 2026
Merged

feat!: delete templates/ and template block routes (CL-8156)#762
TheGreatAxios merged 8 commits into
mainfrom
cl-8156-delete-templates

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Owner ruling: get rid of templates/ and anything that says routes -- fully on native workflows. A new workbench is a plain tenant + Myra (CL-8154's converge path).

What changed

Deleted:

  • templates/ (@workbench/templates): the three shipped WorkbenchDefinition bundles (code-review, gtm, due-diligence), instantiate.ts, settings.ts, participant-agent-requests.ts.
  • apps/web's template-picker feature: workbench-templates.ts, workbench-templates-api.ts, the prefab card grid + library read in new-workbench-picker.tsx, and instant-agent-create.ts's createWorkbenchFromTemplate instantiation path (now just createWorkbench: mint a blank room, invite selected agents, send an opening message).
  • packages/artifacts-hub/src/template-library.ts -- dead code (never mounted in apps/hub, no remaining caller).
  • The install-template eval step/capability and the github-pr-review-factory eval case that drove it.

Renamed (kept -- real, unrelated functionality):

  • apps/hub/src/templates/template-block-routes.ts -> apps/hub/src/catalog-blocks/catalog-block-routes.ts. This route (POST /template-blocks/:assetName/deploy) is not workbench-template-specific -- CL-7073 generalized it to deploy any workflows/* catalog package on demand, and the Routines page's "Available" section depends on it independently of the template picker. Renamed the module/mount away from "templates" naming (createCatalogBlockRoutes, POST /catalog-blocks/:assetName/deploy) rather than deleted; apps/web's routines-api.ts gained deployCatalogBlock to replace the deleted workbench-templates-api.ts's deployWorkbenchTemplateBlock.

Moved home:

  • CONNECTOR_REGISTRY and MCP_PRESETS (templates/connectors.ts) folded back into packages/connections/src/registry.ts and mcp-presets.ts -- CL-7384 had split them out into the template package; with that package gone, they live back where every real consumer (plugins-ui, connections-tools, onboarding, settings-ui, connect-service-actions, plugins-page, the hub) can import them from @corbits/connections/registry / @corbits/connections/mcp-presets.
  • Jimmy's quick-create request (@corbits/chat-ui's JIMMY_QUICK_CREATE) now builds straight off @corbits/jimmy-agent/metadata instead of through the deleted template barrel.
  • WORKFLOW_CATALOG and its helpers repointed at @corbits/workflows/catalog everywhere (client-bootstrap.ts, myra-workbench.ts, agent-directory, onboarding, settings-ui, workflows/assistant tests).

Importer -> action table

File Action
apps/web/src/client-bootstrap.ts, myra-workbench.ts WORKFLOW_CATALOG -> @corbits/workflows/catalog
apps/web/src/connect-service-actions.ts, pages/plugins-page.tsx, shell/provider-health-banner.tsx connectors -> @corbits/connections/{registry,mcp-presets}
apps/web/src/instant-agent-create.ts trimmed to createWorkbench (blank mint only)
apps/web/src/pages/new-workbench-picker.tsx prefab grid + library read deleted
apps/web/src/workbench-templates{,-api}.ts deleted
apps/web/src/pages/routines-page.tsx, routines-api.ts deployWorkbenchTemplateBlock -> new deployCatalogBlock against the renamed hub route
packages/agent-directory/* catalog helpers -> @corbits/workflows/catalog
packages/artifacts-hub/src/template-library.ts deleted (dead)
packages/chat-ui/src/api.ts JIMMY_QUICK_CREATE built from @corbits/jimmy-agent/metadata
packages/code-review (chat) not touched -- deleted by a concurrent PR (T5c)
packages/connections-tools, packages/connections/src/routes.ts comment-only; connections-tools version bumped 0.0.9 -> 0.0.10
packages/evals install-template step + github-pr-review-factory case deleted
packages/onboarding/* connectors + catalog -> native homes
packages/plugins-ui/*, packages/settings-ui/* connectors -> @corbits/connections/*
packages/workflows, workflows/assistant test-only importers repointed
apps/hub/src/templates/template-block-routes.ts renamed to apps/hub/src/catalog-blocks/catalog-block-routes.ts (kept, generic)
scripts/e2e/browser/walkthrough.ts drives the trimmed picker

Features deleted from the UI

  • The "Code review" / "Due Diligence" prefab cards on /new and their onboarding walkthrough (connect-github card post, pending-connections settings patch) via the template path.
  • The template library fetch (GET /library/templates) on the picker.

Left alone

  • packages/chat (connect-pending.ts comment mentions only) -- another agent is deleting this package entirely (T5c); did not touch it.
  • apps/web/src/pages/onboarding-page.tsx and apps/web/src/myra-source.ts -- explicitly out of scope (concurrent Myra-deploy-input work).

Test plan

  • bun run typecheck -- clean except two pre-existing unrelated failures (@corbits/chat/blocks/@corbits/chat/parts module resolution in packages/chat-ui/test/*, last touched by an unrelated commit)
  • bun run lint -- clean except the 3 pre-existing unused-var errors in apps/hub/src/index.ts
  • bun run check:structural -- all green, report-error baseline regenerated
  • bun --cwd apps/web test -- 884 pass, 0 fail
  • bun run test (full monorepo) -- all green

https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

CL-8156

@TheGreatAxios
feat(connections): fold the concrete connector set back into the package
951bae1 
CL-7384 split CONNECTOR_REGISTRY and MCP_PRESETS out into
templates/connectors.ts so the connections package stayed a pure
generic library. CL-8156 deletes templates/ entirely, so this data
comes back to its one remaining home: packages/connections/src/registry.ts
and mcp-presets.ts.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
feat(hub)!: rename template-blocks deploy route to catalog-blocks
625b997 
The on-demand workflow-deploy route under apps/hub/src/templates/ was
never actually workbench-template-specific (CL-7073 generalized it to
any workflows/* package) -- the routines page's "Available" section
drives it independently of workbench templates. Rename the module and
its mount out of the deleted templates/ naming: createTemplateBlockRoutes
-> createCatalogBlockRoutes, POST /template-blocks/:assetName/deploy ->
POST /catalog-blocks/:assetName/deploy.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
feat(artifacts-hub)!: delete the dead template-library module
67929db 
createTemplateLibraryRoutes/seedTemplateLibrary were never mounted in
apps/hub and had no remaining caller outside this package once
CL-8156 deletes workbench template picking -- dead code, not a
migration.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
feat(evals)!: delete the install-template eval capability
489bc9a 
The install-template step, its Target.installTemplate capability, and
the github-pr-review-factory case that drove it all rode the
workbench-template instantiation path CL-8156 deletes. Deleted rather
than ported: the underlying code-review reviewer roster and workflow
still deploy natively (agent-directory create + the catalog-blocks
route), just never through a "kind of workbench" bundle.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
feat(web)!: delete workbench template picking; a new workbench is a p…
9c5f3e9 
…lain tenant + Myra

Deletes the template-picker feature entirely: workbench-templates.ts,
workbench-templates-api.ts, the prefab card grid and library read in
new-workbench-picker.tsx, and createWorkbenchFromTemplate's
instantiation path in instant-agent-create.ts (now just createWorkbench:
mint a blank room, optionally invite selected agents, send an opening
message). The picker keeps its prompt box, agent picker, and empty-
channel button -- the readiness gate (Myra must be deployed before a
room can invite anyone) is unchanged.

@corbits/chat-ui's Jimmy quick-create row now builds its create-agent
request straight off @corbits/jimmy-agent/metadata instead of through
the deleted @workbench/templates barrel.

Every other @workbench/templates import (WORKFLOW_CATALOG,
CONNECTOR_REGISTRY, MCP_PRESETS, ...) is repointed at its native home:
@corbits/workflows/catalog and @corbits/connections/{registry,mcp-presets}.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
feat!: delete templates/ (@workbench/templates)
740b727 
Deletes the workspace: the three shipped WorkbenchDefinition bundles
(code-review, gtm, due-diligence), instantiate.ts, settings.ts (already
a re-export of @corbits/connections/template-settings),
participant-agent-requests.ts, and connectors.ts (moved to
@corbits/connections in the prior commit).

Every remaining importer (agent-directory, connections-tools,
connections, onboarding, plugins-ui, settings-ui, workflows,
workflows/assistant) is repointed at the native homes this data always
belonged to: @corbits/workflows/catalog for WORKFLOW_CATALOG and its
helpers, @corbits/connections/{registry,mcp-presets} for
CONNECTOR_REGISTRY/MCP_PRESETS. connections-tools bumps its version
(0.0.9 -> 0.0.10) for the comment-only src/ touch; the browser
walkthrough script's create-workbench flow drives the trimmed picker
(no prefab grid). report-error-baseline.txt regenerated: the two
stale entries under the deleted templates/ and template-library.ts
paths are gone.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
Update docs: drop @workbench/templates mentions
a3c27d9 
Comment-only cleanup in code-review/README.md, workflows/README.md, and
chat-ui's connect-github-actions.ts left over from the templates/
deletion.

Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
@TheGreatAxios
fix(hub): drop dead scheduler imports left over from rebase onto main
e157016
@TheGreatAxios
TheGreatAxios force-pushed the cl-8156-delete-templates branch from 521e911 to e157016 Compare September 17, 2026 17:34
@TheGreatAxios
TheGreatAxios merged commit d7c81aa into main Sep 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheGreatAxios