Repository navigation
feat(hub)!: delete dead mounts run-key-history, preferences, bench-model-policy, resolved-offerings (CL-8158) - #759
Merged
Conversation
…del-policy, resolved-offerings (CL-8158) CL-8155's inventory found zero web callers for four apps/hub/src/index.ts mounts. Hard cutover, no fallbacks: - @corbits/run-key-history (diagnostics-only mount plus its agent.deploy.ack listener) and @corbits/preferences (a client built but never imported — the only caller, chat-ui's dormant WorkbenchSettingsSurface/NotificationsSection, is unreachable from web) are deleted outright, packages and all. - bench-model-policy's HTTP mount is deleted; the store and bench_model_policy table stay, since a workflow-catalog read still uses them. - catalog/resolved-offerings is deleted; its only caller (packages/onboarding's seed CLI) is dead post-T7. scripts/db-setup.ts drops the run_key_history and preferences Postgres schemas forward-only, mirroring the routines-schema handoff. Updated the no-product-tenancy and browser-safe-subpaths check allowlists and regenerated tsconfig.build.json's project references. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CL-8155's inventory found zero web callers for four
apps/hub/src/index.tsmounts. Hard cutover, no fallbacks:run-key-history— deleted outright, package and all: the mount was diagnostics-only (no web caller), and itsagent.deploy.acklistener/store go with it.preferences— deleted outright: the client was built but never imported by anything reachable from web. Its one real caller,packages/chat-ui's dormantWorkbenchSettingsSurface/NotificationsSection, is itself unreachable fromapps/web(superseded bypackages/settings-ui's own notifications section) — that dead notifications wiring is removed too so the package deletion is a clean cutover, not a fallback left dangling.bench-model-policy— the HTTP mount is deleted, but the store andbench_model_policytable stay: a workflow-catalog read still usesbenchModelPolicy.store.getPolicy.catalog/resolved-offerings— deleted; its only caller waspackages/onboarding's seed CLI, dead since T7.scripts/db-setup.tsdrops therun_key_historyandpreferencesPostgres schemas forward-only (mirrors the existing routines-schema handoff pattern). Updated theno-product-tenancyandbrowser-safe-subpathscheck allowlists, regeneratedtsconfig.build.json's project references, and updateddocs/package-migrations.md.Not in this PR: the checklist's fifth item — folding
createWorkflowDetailRouteonto the stockvendor/intx/hub-apidefinitions route — is a distinct, larger-blast-radius change (the stock route has no per-definition detail endpoint at all; folding it means either patching vendored code or dropping steps/lifecycle/grants/credential-bindings from the workflow detail page). Left alone rather than guessed at; flagging for a follow-up.Test plan
bun run typecheck— clean (two pre-existing, unrelated failures inpackages/chat-ui/test/{connect-github-block-container,tool-activity-view}.test.tsxalready present onorigin/mainat the branch point)bun run lint— cleanbun run check:structural— clean (report-error: 0 new findings, 0 stale baseline entries)bun --cwd apps/web test— 919 passbun --cwd packages/chat-ui test— 904 passbun --cwd packages/inference-catalog test— 71 pass, 4 DB-gated skipped locallybun --cwd apps/hub test— 203 pass, 31 DB-gated skipped locally (no local Postgres port free; CI provisions one)https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG