Repository navigation
Cut hub over to stock Interchange composition - #741
Merged
Merged
Conversation
Summary: - Delete Workbench product-policy mounts, guards, and onboarding from apps/hub (artifacts/memory/skills/slack-tag mounts, tenant-create guard/onboard, dispatch tenant guard, signup tenancy, connection-live reconcile) and repair composition wiring/imports. - Rename WORKBENCH_CHAT_IDLE_REAP_MS to HUB_CHAT_IDLE_REAP_MS; drop product-only signup/genesis knobs (WORKBENCH_SIGNUP, WORKBENCH_ALLOWED_EMAIL_DOMAINS, WORKBENCH_DEFAULT_TENANT/ORG_SLUG). - Update wiring-pin tests for cut routes; drop the dead draft-routes pin; shrink the report-error baseline to the remaining matches. Verification: - bun run --cwd apps/hub test: 216 pass, 0 fail (plus 1 file-level isolation-harness error: the shared test database carries an unknown chat migration 0031_workbench_tenancy_drop, so the live-sidecar probe cannot create workbenches; unrelated to this change). - bun run --cwd apps/hub typecheck: clean. - bun run lint: 0 errors (10 pre-existing warnings in unrelated packages). - bun run check:structural: exit 0, 18 checks ok.
Summary: - test/isolation/setup.ts, scripts/e2e/harness.ts: drop WORKBENCH_SIGNUP/ALLOW_UNVERIFIED_EMAILS boot env (stock composition leaves signup ungated). - scripts/dev.ts: drop WORKBENCH_SIGNUP=open injection and the signup_closed seed branch. - scripts/e2e/local-rip.test.ts: closed-signup hop becomes signup-stays-ungated against the main hub. - .env.example: remove WORKBENCH_SIGNUP/WORKBENCH_ALLOWED_EMAIL_DOMAINS/ALLOW_UNVERIFIED_EMAILS/WORKBENCH_DEFAULT_TENANT/ORG_SLUG blocks. - docs/TENANCY.md, docs/local-rip.md: describe ungated stock signup, caller-chosen root slug, removed tenant-create guard. Verification: - Hub typecheck (apps/hub tsc --noEmit): exit 0. - prettier --check + eslint on all touched files: clean. - Worktree grep for deleted keys: only intentional historical mentions remain (listed in report).
Summary: - access-policy: drop envSignupMode/envAllowedDomains bootstrap from evaluateSignupGate/checkSignupGate; rowless evaluation is closed defaults. allowUnverifiedEmails stays as an explicit caller option. - bench-ui: delete SignupMode, DEFAULT_SIGNUP_MODE, emailAllowedForSignup, parseAllowedEmailDomains, parseSignupMode and their exports/tests; README prose updated. - settings-ui: remove envSignupClosed notice/probe from AccessPolicyBlock/Editor; delete getAuthConfig/AuthConfig client for the removed /api/auth-config endpoint and its string/test. - hub-api-client: remove signup_closed env-fix branch from authenticate; failure prose points at hub logs, never an env key. - onboarding: thread the trimmed gate options through genesis/provision/routes; gate-specific tests wire the policy explicitly, other tests run without a gate. Verification: - bun test in packages/access-policy (36 pass), packages/onboarding (223 pass), packages/bench-ui (22 pass), packages/settings-ui (161 pass), packages/hub-api-client (13 pass) - bun run typecheck: exit 0 - bun run lint: exit 0 (0 errors, 10 pre-existing warnings) - bun run check:structural: exit 0
…config Stock Interchange exposes no sign-in discovery endpoint, so the hub stops serving GET /api/auth-config and the web sign-in screen draws its OAuth buttons from a static client list (SOCIAL_SIGN_IN_PROVIDERS) instead of probing the hub. better-auth still decides which providers actually work. The settings-ui oauth-configured probe is untouched.
Contributor
Author
|
Superseded by #742, which has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
There is no parent bench: the client drives stock Interchange and the hub composes it. This branch cuts the hub over to stock Interchange composition — removing retained signup env-key code, stale tenancy mounts/guards, and contract shims without replacement — a hard cutover to the stock composition surface.
Key commits
fd3a43e2feat(hub)!: cut over to stock Interchange compositiona648d53cdocs(hub): fix stale cutover comments and README6bb78ca9docs(hub): clear stale signup/tenancy env references post-cutover1edc1b58test(hub): rewrite local-rip provision hops against stock tenant/agent routes368cd0bcrefactor(hub): cut retained signup env-key code from four packagesc0a9070drefactor(auth): remove /api/auth-config, sign-in buttons from client config9aff043atest(web): keeper for failed social sign-in surfacing better-auth messageVerification
packages/hub-api-client/src/hub.test.ts(new stock-composition coverage),scripts/e2e/local-rip.test.tsrewritten against stock tenant/agent routes,genesis,gate/policy,auth, settings-ui API suites updated;tenancy-contractssuites deleted with the code.bun run checkgate runs in CI on this PR.Notes
cl-<id>-<slug>once filed.