Repository navigation
feat(hub): compose notify delivery deps with mailbox read-back - #735
Merged
Merged
Conversation
Related to CL-7238
Rebase onto origin/main (post tenancy deletion) mis-resolved the notify import block, keeping references to files already removed on main (tenant-create-guard, access-policy, memory-mount, skills-mount). Restore main's direct createHubNotifyDeliveryDeps composition. Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
TheGreatAxios
force-pushed
the
cl-7238-hub-wiring
branch
from
September 17, 2026 16:13
1ebaa15 to
8972500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composes the hub's notify deps through a single factory that wires the workbench mailbox delivery together with the crash-window read-back from #734, so redelivered store rows resolve to queued dispatches on the prod path.
Related to CL-7238
Summary
apps/hub/src/notify-delivery.ts: newcreateHubNotifyDeliveryDepsfactory — delivery adapter + addressing + dispatch store + sink registry, withresolveExistingMailIdswired from the composed mailbox db.apps/hub/src/index.ts: hub composesnotify:through the factory; drops the inline literal and the dead plain-sink import.apps/hub/test/notify-delivery.test.ts: prod-closure test through the composed deps — seeds a queued row, resolves via composed read-back, queues dispatch.Verification
bun test apps/hub/test/notify-delivery.test.ts: 3 pass (green on first run against wired deps; red proven pre-wiring in PR feat(inbox): wire CL-7238 mail id read-back through the real adapter #734's e2e).bun test packages/inbox packages/notify apps/hub: 375 pass, 6 fail — the 6 are pre-existing on pristine origin/main 739a87e (verified via detached baseline worktree, same 6 fail with zero changes).bun run typecheck: clean.prettier --check+eslinton touched files: clean.