Skip to content

test(chat): keeper tests for DM pin and turn-queue races - #733

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-keeper-chat-tests
Sep 15, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-keeper-chat-tests

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

Keeper tests, test-only — no product code touched.

  • Step 2 (CL-7108 DM pin): rebuilt the warm-mailbox DM fixture on the pin's computed keys, keeping exactly one wire-literal test; added a non-DM-settings-never-take-the-DM-path test (group chat carrying a definition id is invisible to findExistingAgentChat, mintAgentDm mints fresh, and the fresh DM is what a later find reopens).
  • Step 3 (turn-queue races): stubbed the error sink via mock.module; added concurrent-runs-never-double-dispatch (five racing runs, Promise.resolve pumps only, no sleeps) and rejecting-drain-reports-refid-and-keeps-draining.

Verification

  • Red-proven: fixture key typo reds 2 pin tests; group-kind flip reds the find half; mint inequality inversion reds the mint half; double-dispatch and report/drain inversions red their keepers — all restored.
  • Concurrent test repeated 50x: 50 pass, 0 fail.
  • packages/chat/src + packages/chat/test: 980 pass, 0 fail. chat package typecheck, prettier, eslint clean.
  • Full bun test packages/chat shows 91 pre-existing packages/chat-ui failures, reproduced on clean main (composer.test.tsx 32/32 fail there too); zero failures in the touched files.

@TheGreatAxios
TheGreatAxios force-pushed the cl-keeper-chat-tests branch 3 times, most recently from ca5d142 to 612bd0a Compare September 15, 2026 22:47
@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) September 15, 2026 23:06
@TheGreatAxios
TheGreatAxios merged commit 535ab32 into main Sep 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant