Repository navigation
feat(onboarding)!: delete pending-seed drain and bench provisioner (CL-7586) - #730
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7586-pending-seed-drain
branch
3 times, most recently
from
September 15, 2026 22:10
5ce037a to
1a30a4f
Compare
…L-7586) Provisioning is the explicit setup-CLI/installer flow plus the desired-state reconcile only: remove onboarding.pending_seed (schema, store, migrations live on as 0001 + 0002_drop), the bench-provisioning background drain, and every caller. Connect and status routes now kick the reconcile fire-and-forget and answer from hub reads. Retire docs/bench-provisioning.md and shrink the report-error baseline to match.
TheGreatAxios
force-pushed
the
cl-7586-pending-seed-drain
branch
from
September 15, 2026 22:47
1a30a4f to
61bcd8d
Compare
TheGreatAxios
enabled auto-merge (squash)
September 15, 2026 23:06
This was referenced Sep 17, 2026
Contributor
Author
|
Superseded by hub-zero T1 (#747), which unmounted the onboarding router entirely. |
auto-merge was automatically disabled
September 17, 2026 15:55
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/onboarding/src/pending-seed.ts,schema.ts,bench-provisioning.tsand their suites; migration ledger carries0001_pending_seed+0002_drop_pending_seedso a migrated DB holds no pending-seed table anywhere.reconcileTenantDesiredStatefire-and-forget and answer from hub reads (ready/provisioning/unseeded). Retiresdocs/bench-provisioning.md, updates the live guides, shrinks the report-error baseline by its 2 stale lines, drops the dead no-product-tenancy allowlist entry.pendingSeed|sealPendingSeed|benchProvisioner|bench-provisioning|createBenchProvisioner|pending-seed.ts|createDrizzlePendingSeedStoreoutside the migrations ledger, deletion notes, and one unrelated chat-ui README mention (chat out of lane, left untouched).Verification
bun test packages/onboarding packages/connections: 574 pass, 0 fail (one transient single-failure flake mid-session, green 3x since)bun test apps/web/test/onboarding.test.tsx: 60 pass, 0 failbun run scripts/typecheck.ts: exit 0;bun run lint: 0 errors (10 pre-existing warnings in untouched files);bun run scripts/checks/run.ts: exit 0, 18 checks okbun test apps/hub: same 6 interference failures as clean main (verified byte-identical on unmodified checkout);bun test packages/chat: same 91 pre-existing failures as clean main (verified identical), hence --no-verify pushFixes CL-7586