Skip to content

Port codex and xai providers into private workspace packages - #688

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7509-in-repo-private-provider-packages-codex-provider-xai
Sep 8, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-7509-in-repo-private-provider-packages-codex-provider-xai

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • packages/codex-provider and packages/xai-provider port the upstream corbitsdev provider repos into private in-repo workspace packages (the ollama-adapter precedent): sources byte-identical to upstream except report-error-ignore annotations on the two deliberate degrade-by-contract catches, with all 14 upstream unit tests ported unchanged.
  • Dependencies resolve through the pinned corbitsdev tags (@corbits/oauth-core#v0.1.1, @corbits/openai-responses#v0.1.0) plus workspace:* @intx/* and catalog arktype; upstream publish metadata and install instructions are dropped.
  • The CodexQuirks-absent failure is pinned as a CodexQuirksError (instance-of asserted, not just toThrow), so a codex source missing productName/environmentTagName fails loudly at adapter resolution.
  • tsconfig.build.json gains the two generated project references; the root workspaces glob picks up both packages.

Verification

  • bun run check exits 0 (typecheck, lint, full test matrix, structural checks incl. tsconfig-references --check, catalog-pins, licenses, report-error).
  • bun test packages/codex-provider packages/xai-provider: 14 pass / 0 fail.
  • git grep proves zero references to the upstream provider repo URLs; the only github: deps are the two pinned corbitsdev tags.
  • Independent review compared every ported file against the upstream sources (byte-identical modulo annotations) and mutation-tested the quirks assertion; returned clean.

Closes CL-7509

Move the upstream corbits-codex-provider and corbits-xai-provider
sources into packages/ as private in-repo packages rather than
consuming them as unpinned github dependencies. Their shared deps are
pinned to the corbitsdev tags (oauth-core v0.1.1, openai-responses
v0.1.0), @intx/* resolve to the workspace, and arktype to the catalog.
Upstream unit tests are ported unchanged; the quirks-absent codex
adapter test now pins the named CodexQuirksError.
@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown

CL-7509

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review (code-review skill) returned clean. Reviewer-of-record checks (commit subject/body style audits, diff-stat binary scan, commit-scope check) ran in-session on the final history; the deeper behavioral read — including a byte-level port-fidelity comparison against both upstream sources and a mutation test of the quirks assertion — ran as an independent review round and returned clean.

@TheGreatAxios
TheGreatAxios merged commit 1ff475e into main Sep 8, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant