Repository navigation
Consume @corbits/oauth-core from a pinned git tag - #687
Merged
Merged
Conversation
Replace the vendored oauth-core copy with the corbitsdev/corbits-oauth-core v0.1.1 tag, which includes the configurable loopback-only callback bind host; the API the connections token session consumes is unchanged.
Contributor
Author
|
Self-review ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/connectionsnow resolves@corbits/oauth-corefrom the pinnedgithub:corbitsdev/corbits-oauth-core#v0.1.1tag (merged upstream commite1e69e6, hash-locked inbun.lock), which adds the configurable loopback-only callback bind host the sidecar-hosted OAuth login needs.vendor/intx/oauth-core/is deleted outright along with its VENDORED.md ledger row and kill-dates entry — the dependency is no longer vendored, per the owner ruling to fix non-Interchange corbitsdev repos upstream and consume pinned tags.createTokenSession,TokenSessionDeps, error classes) is unchanged; stale "vendored" comments in the consumers are updated.Verification
bun run checkexits 0 (typecheck, lint, full test matrix, structural checks) before the commit;bun run check:structural killdatesexits 0 with the oauth-core rows removed.bun test packages/connections/src/token-session.test.tsexits 0 against the git-dep copy.git grepproves zerovendor/intx/oauth-corereferences remain; the lockfile resolves the tag toe1e69e6with an integrity hash.Closes CL-7512