Skip to content

Drop the ambient dev sidecar from local dev - #682

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7496-drop-ambient-dev-sidecar-bun-run-dev-relies-on-hub
Sep 7, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-7496-drop-ambient-dev-sidecar-bun-run-dev-relies-on-hub

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #684, which landed the ambient dev-sidecar removal itself (upstream Interchange commit 064e997d removed ambient/shared sidecar authentication, so the dev bootstrap's bare sidecar row + static-token login could never register). This PR finishes the removal with the pieces #684 did not cover:

  • scripts/reset.ts no longer removes the repo-root .data/sidecar directory — nothing creates it anymore; provisioned sidecar state lives under the hub data dir, which reset already covers
  • scripts/reset.test.ts expectations updated to match
  • README's reset paragraph and docs/local-rip.md describe hub-provisioned sidecar capacity instead of the retired bootstrapped path

Closes CL-7496.

Verification: bun test scripts/reset.test.ts 9/9 in the worktree; check:structural green; CI runs the full gate matrix here. Pre-push hook skipped with SKIP_WORKBENCH_HOOKS solely because of the pre-existing @corbits/workflows local-env failures tracked in CL-7499 (CI is unaffected).

@linear-code

linear-code Bot commented Sep 7, 2026

Copy link
Copy Markdown

CL-7496

PR #684 already removed the ambient dev sidecar bootstrap, but reset still
removed a repo-root .data/sidecar directory that nothing creates anymore, its
test still expected it, and the README/local-rip dev-start wording still
described bootstrapped sidecar state. Reset now covers only the hub data dir
(which holds provisioned sidecar state), and the docs describe
hub-provisioned capacity.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7496-drop-ambient-dev-sidecar-bun-run-dev-relies-on-hub branch from 1dad8a2 to ff0ad74 Compare September 7, 2026 17:10
The re-arm test asserted a visible-expiry boundary with a 20ms margin
under real timers; a CI runner stretched a single await past 120ms and
the indicator expired before the re-arm, failing the shard. The expiry
doubles to 500ms and every assertion margin is now at least 150ms, so
runner jitter cannot flip before-expiry / after-expiry either way.
@TheGreatAxios
TheGreatAxios merged commit f6c7fa0 into main Sep 7, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant