Repository navigation
CI: run each e2e suite as its own job (CL-7485) - #672
Merged
Merged
Conversation
Pins the expected shape of an e2e-plan/e2e-suite/e2e job trio and a list-suites helper that folds the non-hub-booting suites (harness, db-gate, db-setup, list-suites) into one "unit" entry.
The e2e job ran every scripts/e2e/*.test.ts suite serially in one job, each booting hub and sidecar against Postgres, so a PR's e2e wall time scaled with the sum of every suite (4 to 12 minutes) rather than the slowest one. An e2e-plan job now lists the suites and feeds them into an e2e-suite matrix job, one job per suite, fail-fast off, each uploading its E2E_LOG_DIR as an artifact. A summary e2e job keeps that name for branch protection while the matrix does the work.
Renames the e2e Postgres job reference to e2e-suite and notes that the e2e-suite matrix job now sets E2E_LOG_DIR and uploads it per suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CL-7485
The
e2ejob ran everyscripts/e2e/*.test.tssuite serially in onejob, each booting hub + sidecar against Postgres — 4 to 12 minutes,
though the slowest single suite is under 3.
scripts/e2e/list-suites.tsprints the suite ids, foldingharness,db-gate,db-setup, andlist-suites(pure-helpertests, no hub boot) into one
unitentry.e2e-planlists the suites;e2e-suiteruns them as afail-fast: falsematrix, keeping the same Postgres service/env/assert steps, and uploads
E2E_LOG_DIRper suite as an artifact.e2ejob (needs: [e2e-suite],if: always()) fails ifany matrix entry didn't succeed, keeping the required-check name
e2efor branch protection.package.json'stest:e2eis unchanged for local use.Before: single
e2ejob, reported 4-12 min wall (slowest suite aloneunder 3 min). After: see this PR's own Actions run for the
e2esummary job's wall time versus a matrix entry's.
Test plan
bun run lintbun test scripts/ci-jobs.test.ts scripts/e2e/list-suites.test.tsbun run typecheck