Skip to content

isolation: give the afterAll shutdown hook headroom past the harness's own kill fallback (CL-7462) #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 6, 2026
Merged

isolation: give the afterAll shutdown hook headroom past the harness's own kill fallback (CL-7462) #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion test/isolation/isolation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,19 @@ if (!databaseUrl) {
await prepareDatabase(databaseUrl);
const hub = await bootIsolationHub(databaseUrl);
const app: AppLike = hub.app;
// `hub.shutdown()` stops the sidecar then the hub in sequence
// (`test/isolation/setup.ts`), and each `stop()` (`scripts/e2e/
// harness.ts`) gives its process up to 5s to exit on SIGTERM before
// escalating to SIGKILL — so a graceful-but-slow exit on either
// process alone can approach Bun's 5000ms default hook timeout, and
// two of them in sequence can exceed it outright. CL-7462: this hook
// timed out at ~5001ms in CI once boot wiring grew (workflow
// allocation/dispatch initialization, extra reconciliation queries),
// pushing shutdown latency on CI's shared runners past the default
// margin even though nothing was actually hung.
afterAll(async () => {
await hub.shutdown();
});
}, 20_000);

// Unique suffix so the suite can rerun against a database that
// already holds rows from a previous run.
Expand Down
Loading