Repository navigation
Re-pin @corbits/artifacts to dc435ba7 (CL-7464) - #652
Merged
Merged
Conversation
Moves all three pins (root, apps/hub, packages/artifacts-hub) from 81049ed2 to dc435ba7, picking up three upstream commits: exporting windowContent from the package index, native Interchange authorization for artifacts, and findOrVersionArtifact for the tenant+title+kind race.
Upstream removed the identity-resolving Identity port and the creatorKind list filter it existed to serve, and dropped SerializedArtifact's ownerName field along with it (display names are now a client-side concern). Updates the three listArtifacts call sites and test fixtures to the new two-argument signature and drops the now-nonexistent field from test literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves CL-7464
Moves
@corbits/artifactsfrom81049ed2todc435ba7inpackage.json,apps/hub/package.json, andpackages/artifacts-hub/package.json, picking up three upstream commits:windowContentfrom the package indexfindOrVersionArtifactto close the tenant+title+kind raceWhat changed
bun.lockregenerated.Identityport (and theanonymousIdentitystub) was removed along with thecreatorKindlist filter it existed to serve, andSerializedArtifact.ownerNamewas dropped. Updated the threelistArtifactscall sites (routes.ts,workflow-routes.ts,template-library.ts) to the new two-argument signature, and dropped the now-nonexistentownerNamefield from two test fixtures.RequireGrant/asset:*grants rather than the package'smountArtifactsHTTP surface, so the native-authorization change upstream needed no adaptation here.template-library.ts'sreconcileEntrystill does its own find-by-title-then-create for a not-yet-seed-tracked template. This looks like the find-then-create racefindOrVersionArtifactcloses, but its clash semantics differ — on a title clash it deliberately returns"kept"and leaves the existing row untouched (protecting a member's own artifact that happens to share a title), wherefindOrVersionArtifactwould revise it with the shipped content. Converting it would be a real behavior change beyond the scope of this re-pin, so it was left as-is.Test plan
bunx tsc --noEmit -p packages/artifacts-hubbunx tsc --noEmit -p apps/hubbun test packages/artifacts-hub(69 pass)bun run check:structural catalog-pins