Repository navigation
e2e: deploy workflows by catalog offering ids (CL-7460) - #651
Closed
TheGreatAxios wants to merge 7 commits into
Closed
TheGreatAxios wants to merge 7 commits into
TheGreatAxios wants to merge 7 commits into
Conversation
The native workflow deploy route now requires sourceOfferingIds/ defaultSourceOfferingId resolved against the tenant's own catalog, rather than a raw provider/baseURL/apiKey source chain. Update workflowDeployBody accordingly, and extract the zero-cost noop catalog chain smoke-webhook.test.ts already built (an anthropic- plugin provider pointed at the hub's noop-inference endpoint) into a shared seedNoopCatalogOffering harness helper. Every deploying e2e suite now seeds or resolves a real catalog offering before deploying: walking-skeleton keeps a never-real placeholder host (assertNeverRealProvider still guards it), chat resolves the offering seedCatalog already planted rather than seeding a second chain, and heartbeat/workbench-digest/smoke-webhook seed the noop chain via the shared helper. cl-6324-launch-proof's section-mode deploy now reuses the offering id the proof already resolved when it narrowed the bench catalog to its pinned model.
Another workflowDeployBody caller CI's typecheck job caught: this stack seeds one catalog offering per real inference target already, so track each one's id and pass it through to the deploy body instead of the raw provider/baseURL/apiKey shape.
1 of 2 tasks
harness.ts's seedNoopCatalogOffering duplicated the exact chain @corbits/seeding's ensureNoopCatalogOffering already plants (CL-7461). Every deploying suite that pointed the offering at the hub's own real noop-inference endpoint (heartbeat, smoke-webhook, workbench-digest) now calls the shared helper instead; walking-skeleton keeps its own local copy, since it deliberately points the offering at an unreachable placeholder host rather than the hub's noop-inference endpoint, which the shared helper does not support.
TheGreatAxios
changed the base branch from
cl-7107-repin-and-re-vendor-audit-against-interchange-main-before-the
to
cl-7461-seed-deploy-offering-ids
September 6, 2026 16:02
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The native workflow deploy route now requires
sourceOfferingIds/defaultSourceOfferingIdresolved against the tenant's own catalog, instead of a rawsources: [{ provider, baseURL, apiKey, model }]chain.scripts/e2e/harness.ts'sworkflowDeployBodystill sent the old shape, so the e2e job failed with 400 across walking-skeleton, chat, heartbeat, smoke-webhook, workbench-digest, andcl-6324-launch-proof.ts.Why
Deploy the same way the native route now expects: by catalog offering id.
workflowDeployBodytakes{ assetId, commitSha, sourceOfferingIds, defaultSourceOfferingId }.The zero-cost noop catalog chain (an
anthropic-plugin provider pointed at the hub's ownnoop-inferenceendpoint) used to be a bespokeseedNoopCatalogOfferingharness helper. This revision drops that duplication:@corbits/seeding(CL-7461, this PR now stacks on #657) exportsensureNoopCatalogOffering, the exact same chainseedTenantitself plants for amodelSource-pinned default workflow, and heartbeat/smoke-webhook/workbench-digest now call that shared helper directly instead of harness's own copy.walking-skeletonkeeps a local helper pointed at its never-real placeholder host (still guarded byassertNeverRealProvider), since the shared helper always targets the hub's realnoop-inferenceendpoint.chat.test.tsresolves the offeringseedCatalogalready plants rather than seeding a second chain.cl-6324-launch-proof.ts's section-mode deploy reuses the offering id the proof already resolves when it narrows the bench catalog to its pinned model.Resolves CL-7460
Test plan
bunx tsc --noEmit -p tsconfig.jsonbunx tsc --noEmit -p packages/longevity-simbun test scripts/e2e/harness.test.tse2ejob.