Repository navigation
Seed deploys only Myra; catalog workflows deploy on demand (CL-7074) - #645
Merged
Merged
Conversation
This was referenced Sep 5, 2026
Cover DEFAULT_WORKFLOWS narrowed to assistant, with echo, workbench-digest, and last-30-days-research moving to an on-demand CATALOG_WORKFLOWS set deployed via the same seeding-library path rather than automatically at signup.
…-days-research to an on-demand catalog (CL-7074) DEFAULT_WORKFLOWS becomes [assistant]. A fresh signup paid a git push and a sidecar deploy probe for three workflows nobody had asked for yet; those now live in CATALOG_WORKFLOWS, exported alongside DEFAULT_WORKFLOWS and CATALOG_TEST_WORKFLOWS, deployed through the same seedTenant path (ensureWorkflowAsset -> pushWorkflow -> ensureDeployment) only when something asks for one by name.
TheGreatAxios
force-pushed
the
cl-7074-seed-only-myra
branch
from
September 5, 2026 03:00
5290ad6 to
a325739
Compare
TheGreatAxios
added a commit
that referenced
this pull request
Sep 5, 2026
…bench (CL-7073) (#646) Fixes CL-7073 Stacked on #645 (cl-7074-seed-only-myra) — target branch is that PR's branch, not main. ## What changed `POST /:assetName/deploy` (`apps/hub/src/templates/template-block-routes.ts`) generalizes from a hardcoded `code-review`-only builder to any `@corbits/seeding` `CATALOG_WORKFLOWS` entry: - `DefaultWorkflow.buildJson` now takes the tenant's real, ordered inference preferences directly instead of a single `ModelSource`, so the same `buildJson` per catalog entry serves both `seedTenant`'s HTTP self-call deploy path and the hub's native in-process deploy path (`apps/hub/src/templates/block-workflows.ts`). - `code-review` moves out of its own hand-rolled builder into `CATALOG_WORKFLOWS` alongside `echo`, `workbench-digest`, and `last-30-days-research` — no special case left in `block-workflows.ts`. - A new `deployableCatalogWorkflow(assetName)` export is the one lookup both the route and any future caller use to ask "is this asset name deployable on demand." - `assistant` (seeded already) and `heartbeat` (`CATALOG_TEST_WORKFLOWS`, test-only) stay unreachable through this route, same as before. - Idempotency is unchanged and already correct: the route's `deployWorkflowSource` port looks up an existing `deployed` `workflow_definition` by asset name first and returns it (`created: false`) rather than deploying again. ## Tests - `apps/hub/src/templates/template-block-routes.test.ts`: new cases deploying `last-30-days-research` through the generalized builder, and asserting `assistant`/`heartbeat` still 404 rather than deploy. - `packages/seeding/test/seed.test.ts`, `packages/seeding/test/routine-launchability.test.ts`, `packages/seeding/test/tool-registry-coverage.test.ts`: updated for the new `buildJson` signature and the `code-review` entry in `CATALOG_WORKFLOWS`. ## Docs `docs/seed-reconciliation.md` gets a new "Deployable through the catalog" section naming both callers and the idempotency contract. ## Scope note This PR generalizes the one existing deploy route and its backend plumbing per the acceptance criteria (new bench's catalog lists digest/research; deploying one creates the definition; a second call no-ops; code-review still deploys with no special case left in block-workflows.ts; heartbeat stays test-only). It does **not** wire the Routines create flow or the invite flow to call this route, or add an "Add" affordance to the scheduled-list UI — investigating `apps/web`'s routine-create stepper and the scheduled-list response closely enough to wire that correctly (in particular: `listScheduledWorkflowDefinitions` only returns definitions with a `ScheduleTrigger`, so a naive "not yet deployed" diff against it would mis-flag already-deployed non-schedule-trigger entries like `last-30-days-research`) is real, separate work I'd rather flag than rush. Recommend a follow-up ticket for the UI wiring. ## Test plan - [x] `bun run --cwd packages/seeding typecheck` - [x] `bun run --cwd apps/hub typecheck` - [x] `bun test packages/seeding` - [x] `bun test apps/hub/src/templates` - [x] `bun run check:browser-safe-subpaths` - [x] `bun run check:tool-package-pins` - [x] `bun run check:licenses` - [x] `bun run check:report-error` - [ ] CI
TheGreatAxios
added a commit
that referenced
this pull request
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-7074