Repository navigation
Add Corbit avatars with deterministic human fallbacks - #636
Merged
TheGreatAxios merged 18 commits intoSep 6, 2026
Merged
TheGreatAxios merged 18 commits into
TheGreatAxios merged 18 commits into
Conversation
Contributor
|
@pratikbuilds csn you drop some screenshots here pls? |
pratikbuilds
force-pushed
the
cursor/corbit-avatar-pastel-fallback-92f0
branch
from
September 4, 2026 15:53
99b6ad4 to
1b8ea26
Compare
Collaborator
Author
|
yes doing it now |
pratikbuilds
marked this pull request as draft
September 4, 2026 16:23
Collaborator
Author
Contributor
|
Looks good @pratikbuilds , rebase to main as needed. Please see what's going on re why it's not passing CI and make sure to open into full PR (non draft) once ready |
TheGreatAxios
marked this pull request as ready for review
September 4, 2026 17:40
TheGreatAxios
requested changes
Sep 4, 2026
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
- Make sure it passes CI please
- Will need to think about where this avatar code should best live for Corbits but this is a great start
Contributor
Self-reviewVerdict: implementation is sound — the Corbit avatar is an inline SVG (no binary asset, no license question), the pastel fallback color and its readable-text pairing are pure functions with deterministic-by-construction tests, and the human/agent split is consistently threaded through chat-ui, settings-ui, and apps/web. No code changes were needed. Findings:
Tests run (from
|
TheGreatAxios
force-pushed
the
cursor/corbit-avatar-pastel-fallback-92f0
branch
from
September 4, 2026 19:22
1b8ea26 to
9af3679
Compare
…names The pastel-fallback avatar classNames (chat-sender-avatar, chat-mention-avatar, chat-member-avatar, chat-thread-avatar-chip) combined with Tailwind override utilities on one line, which broke the check's class-list heuristic and let "chat" match as banned copy. Renamed the classes (and their styles.css rules) to drop the chat- prefix everywhere they're used.
The prior commit dropped the retired chat- prefix from the avatar className (chat-member-avatar -> member-avatar) to satisfy check:ui-vocabulary, but left these tests querying the old class, so they matched zero elements.
TheGreatAxios
force-pushed
the
cursor/corbit-avatar-pastel-fallback-92f0
branch
from
September 4, 2026 19:52
dad346e to
997d3de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
packages/chat-ui/src/avatar.tsxValidation
bun test packages/chat-ui/src/avatar.test.tsx packages/chat-ui/test/avatar-composition.test.tsxbunx tsc --noEmit -p packages/chat-ui/tsconfig.jsonbun run --cwd apps/web buildbun run checkis blocked before lint/tests by pre-existing vendored@intxtype mismatches in the hub and sidecarFollow-up CL-7478 moves the pastel palette into react-ui tokens and removes the DESIGN.md exception added here.