Repository navigation
Refuse hub git-on-disk init inside an existing work tree - #538
Merged
TheGreatAxios merged 4 commits intoAug 31, 2026
Merged
TheGreatAxios merged 4 commits into
TheGreatAxios merged 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun loads repo-root .env, so tests inherit HUB_DATA_DIR=.data/hub inside the work tree. The hub git-on-disk init then walks up to the enclosing .git, and a genesis commit can land on the working branch and delete the checkout.
This change refuses hub boot when HUB_DATA_DIR sits inside an existing git work tree (local-dev opt-in: HUB_ALLOW_GIT_INSIDE_WORK_TREE), strips inherited GIT_DIR / GIT_WORK_TREE from seed workflow pushes, adds test/disposable-hub-data-dir.ts for tests that boot the hub or exercise seed/deploy git paths, and adds check:hub-git-safety so hub/seed junk commits fail CI.
Tests that only mock deploy/seed (catalog shape, pending-seed store, fetch stubs, sidecar routers with their own mkdtemp) do not install the fixture.