Repository navigation
Working label: shows from a bench's first message, with the Corbits mark - #1115
Conversation
The /new composer and its send button stay disabled until workspace roles have loaded (CL-9780). Suites that typed straight away lost the input and stalled on /new waiting for a bench that was never created. One shared startWorkbench(page, message) helper in e2e/lib/first-run.ts now waits for both before typing and clicking, and every suite that starts a bench uses it.
After creating a bench from /new, the thread shows the working label while the opening message waits on the worker to start and reply.
… mark The opening message is sent by PendingOpeningMessage, which never marked a turn pending, so a new bench showed nothing while its worker started and replied. The send now marks the turn pending (and clears it on error), and the label shows under the pending message while the worker is still starting; once live, the page's own label takes over until the reply lands. The label now pairs react-ui's ThinkingMark (Silk) with the existing shimmering ThinkingLabel.
9398915 to
b6e487b
Compare
|
Here is a preview of it. Screen.Recording.2026-10-08.at.6.09.24.PM.mov |
TheGreatAxios
left a comment
There was a problem hiding this comment.
Much improved...I think in the next couple of iterations I want to change the order of operations, cleanup the thinking during active chat, fix width, etc; but this solves the issue at hand nicely
|
Resolved the conflicts with main in this merge update.
Validation: typecheck, lint, formatting, and all four affected browser tests passed. The browser tests cover the first reply, follow-up, artifact creation, worker naming/rename, setup, tenant isolation, and composer layout.
|
Summary
A new bench showed no working label while its first message waited on the worker. The opening message is sent by
PendingOpeningMessage, which never marked a turn pending. It now does, and the label also gets react-ui's animated Corbits mark (Silk) beside the shimmer text.While the worker is starting, the label shows under the pending message. Once the worker is live, the send marks the turn pending and the page's own
WorkingLabeltakes over until the reply lands, so the two never show together.Browser suites that start a bench from
/newnow share onestartWorkbench(page, message)helper ine2e/lib/first-run.ts. It waits for the composer and send button to be enabled first (CL-9780).reply,zero-to-one, andfirst-runtyped into a still-disabled composer and stalled on/new;composer-layout,ollama-chat, andsetuphad the same race.Evidence
e2e/browser/reply.test.tsfails at the new check. After creating a bench from/new,.chat-thread-workingnever appears: the thread shows "Say hello" and no label.After: passes. The label appears as the bench opens and clears when the worker's reply lands.
Checked in a live bench: the label with the mark appeared within a second of the bench opening, stayed through "Sending once the agent is ready…" and the send, and cleared when the worker's greeting arrived about 8s later. Follow-up messages show it as before.
Merge Danger
Door: two-way
UI and e2e only; no schema, API, or data changes. Reverting restores the old behavior.
Blast Radius: bench thread
The working label row now includes the mark. Related but not changed here: #1116 (the first message can be sent to the wrong bench when switching benches early).