Repository navigation
Process provisioner: binding fingerprint survives hub restarts (CL-9918) - #1107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9918.
Problem: the process provisioner's binding fingerprint included the hub's port-derived WebSocket URL and the sidecar's absolute entry path. A hub restart that changed either left existing allocation rows matching no provisioner, so the reconciler retried them forever without releasing or replacing them.
Fix: the fingerprint is now
process:v1:${role}. It identifies the backend, and port or install path don't change compatibility.Reproduced: hub A deploys a worker, then hub A and its sidecar are killed and hub B boots on the same database with a new port. The allocation row was still
allocatedafter 300s. With the fingerprint patched to hub B's value, the row was released at about 126s withsidecar_connect_failed.Tests: the new test fails on main and passes with the fix. Typecheck, lint, fmt:check and the hub tests pass.
Note: existing rows carrying the old fingerprint stay stranded once. Reset the database after this lands.