Repository navigation
hub: a run's first reply becomes a chat bubble (CL-9907) - #1104
Merged
Merged
Conversation
…rts errors (CL-9907)
…elivered (CL-9907)
…onnect abandon (CL-9907)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: a worker's first reply never became a chat bubble. The run's event collector was only created on its first outbound mail (after inference.start), so the reply's parts were dropped; and mailbox-persist checked a stale pre-ensure sessionId, so session_mail was never written for that mail.
Fix: wrap the hub's event collector registry with
withLazyRunCollector(collector is created viaensureRunSessionon a run's first event, per-address ordering preserved), and re-resolve the sender afterensureRunSessionin mailbox-persist.Reproduced: new DB suite e2e/workflows/first-reply-session.test.ts failed on origin/main code (no collector created / upstream persistMail not called) and passes now.
Gates: typecheck, lint, fmt:check, e2e suite (29 pass) with local Postgres.
bun run testsince origin/main reported failures only for packages with no test files.