Repository navigation
mailbox send: a finished worker answers 409 with a plain message (CL-9908) - #1103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: sending a chat message to a finished worker showed "The workbench could not be reached (500)." The stock trigger route answers 409 workflow_run_terminal; the mailbox deliver threw a plain Error, which the mailbox mount does not catch, so Hono returned 500.
Fix: the deliver rethrows a 409 as an HTTPException(409) (not reported as an error); the web maps 409 to "This worker has finished its work and can't take new messages." Other statuses unchanged.
Reproduced: new tests failed on origin/main code (hub got 500 instead of 409; web got the unreachable message).
Gates: focused tests (apps/hub mailbox-send.test.ts, apps/web threads-api.test.ts), tsc for apps/hub and apps/web, lint, fmt:check. Full typecheck/test skipped: machine load > 200.