Repository navigation
chat wire: id leak guard mirrors every generateId prefix (CL-9910) - #1102
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-9910-id-leak-prefixes
branch
from
October 4, 2026 22:56
1764262 to
10ef858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
ID_PREFIX_WORDScovered 6 of 27generateIdprefixes (missing e.g. pky, crd, ses, apr, sig, wdv, tp), so those ids could render to users. Docs and the guard header also pointed at nonexistentpackages/chat/packages/hub-common.Fix: hand-mirror all 27 prefixes (ids are
<prefix>_+ 32 hex; the regex already handles 2-lettertp); correct stale paths in the guard header and docs/chat-wire-contract.md.Repro: new test generates one real id per kind; 21 failed on main, all pass now.
Gates: typecheck, lint, fmt:check, test (CHECK_SINCE=origin/main) run; unrelated packages report 'no test files' pre-existing.