Repository navigation
web chat: normalize CRLF in frameBody so the roster strips from user bubbles (CL-9909) - #1100
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-9909-crlf-roster
branch
from
October 5, 2026 00:34
e116a05 to
5cb9f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: @corbits/mailbox builds frames with CRLF;
frameBodykept the \r, sostripRosternever matched and user bubbles showed the Participants block andtoinstruction.Fix:
frameBodynormalizes CRLF to LF (covers agent bodies too).Reproduced: red test builds a frame with
buildMailFrame+appendRoster, runsframeBodythenstripRoster; failed on main with \r\n in the output, passes now.Gates: focused tests only (load avg >70):
bun test src/chatin apps/web, lint, fmt:check, typecheck (since origin/main) all green.